Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix #0016570: Page content is forgotten when user clicks [Back] button #202

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

grangeway commented Jun 1, 2014

By default we disable $g_allow_browser_cache in all circumstances.

The config value is commented out in config_defaults.inc.php. In fact, thraxisp
added the config option in 2005 in the commented out state.

It would appear the DHX re-ordered this call when implemented require_api

The above code is only in 1.3 and not in the 1.2 series, so the above fix should
be safe to apply.

We probably need to consider whether we actually want to remove this configuration option

After all, it's a configuration option we've probably never had anyone use in 5 years
so I expect that the value of it is rather....

@grangeway grangeway Fix #0016570: Page content is forgotten when user clicks [Back] button
By default we disable $g_allow_browser_cache in all circumstances.

The config value is commented out in config_defaults.inc.php. In fact, thraxisp
added the config option in 2005 in the commented out state.

It would appear the DHX re-ordered this call when implemented require_api
- see:

 2d5455c

The above code is only in 1.3 and not in the 1.2 series, so the above fix should
be safe to apply.

We probably need to consider whether we actually want to remove this configuration option

After all, it's a configuration option we've probably never had anyone use in 5 years
so I expect that the value of it is rather....
0dcfcbd
Contributor

grangeway commented Jun 1, 2014

This is to fix http://www.mantisbt.org/bugs/view.php?id=16570 in Mantis Bug tracker, reported by atrol

Owner

vboctor commented Jun 2, 2014

+1

Owner

vboctor commented Jun 15, 2014

Is this just pending reviewing by others on the team? Let's see if we can get it in.

Member

atrol commented Jun 15, 2014

+1

Contributor

grangeway commented Jun 15, 2014

(btw, gonna be a pain here - are these 2 +1's based on the fact I've done some analysis or have you done some testing?)

Member

atrol commented Jun 15, 2014

I tested bug_report_page.php

BTW, the issue was not reproducible with Safari (maybe a hint for the captcha issue http://www.mantisbt.org/bugs/view.php?id=16564)
It seems that the Safari caching strategy is too aggressive.

Owner

vboctor commented Jun 30, 2014

@grangeway is this ready to be checked in given that @atrol has tested it?

Contributor

grangeway commented Jul 14, 2014

Merged with d508493

@grangeway grangeway closed this Jul 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment