Code Standards/PHP Doc improvements #211

Merged
merged 1 commit into from Jun 30, 2014

Conversation

Projects
None yet
4 participants
@grangeway
Contributor

grangeway commented Jun 15, 2014

This is the first commit on this branch.

I'll group them into batches so it might be feasible to have some sort of review (well..)

Batch 1:
Improvements to code base to follow coding standards (variable naming)
Improve phpdoc validation (formatting and types of attributes) - core api's E->Z so far.
Add type hints.

Batch 2: (to follow in an hour) will be core api's A-E and rest of code base.

I'll create a separate pull request to this one to cover a build process that any of us can run. Before doing that, i'll send a mantisbt-dev list email to get feedback on what OS's/tools our core developers run so I can test process validation scripts against those tools/OS's

@vboctor

This comment has been minimized.

Show comment
Hide comment
@vboctor

vboctor Jun 15, 2014

Member

+1 - I would suggest adding the rest of the changes to the same pull request and do a bunch of testing before checkin. There is not much to review here. The changes are good, but hopefully no missed cases of changing the variable name in one spot but not another.

Member

vboctor commented Jun 15, 2014

+1 - I would suggest adding the rest of the changes to the same pull request and do a bunch of testing before checkin. There is not much to review here. The changes are good, but hopefully no missed cases of changing the variable name in one spot but not another.

@dregad

This comment has been minimized.

Show comment
Hide comment
@dregad

dregad Jun 16, 2014

Member

+1

Please avoid the proliferation of pull requests, and stick all the related changes under this one - makes it easier to review and less confusing when there are discussions.

Member

dregad commented Jun 16, 2014

+1

Please avoid the proliferation of pull requests, and stick all the related changes under this one - makes it easier to review and less confusing when there are discussions.

@dregad

This comment has been minimized.

Show comment
Hide comment
@dregad

dregad Jun 16, 2014

Member

BTW that was a +1 on principle - I have not actually tested this and I hope you've done this carefully enough so as to not introduce any regressions this time around.

Member

dregad commented Jun 16, 2014

BTW that was a +1 on principle - I have not actually tested this and I hope you've done this carefully enough so as to not introduce any regressions this time around.

@atrol

This comment has been minimized.

Show comment
Hide comment
@atrol

atrol Jun 16, 2014

Member

+1 on principle, had a cursory look but no tests.

Member

atrol commented Jun 16, 2014

+1 on principle, had a cursory look but no tests.

Code Standards/PHP Doc improvements
Improvements to code base to follow coding standards,
and improve phpdoc validation from PHP Codesniffer rules

@grangeway grangeway merged commit 5458f70 into mantisbt:master Jun 30, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
@grangeway

This comment has been minimized.

Show comment
Hide comment
@grangeway

grangeway Jun 30, 2014

Contributor

I'll send a list mail tomorrow + get a phpcodesniffer ruleset up for review - was planning on doing that tonight but it's 00:40 and it's just taken me ages to test + deal with merge conflicts on this branch.

Contributor

grangeway commented Jun 30, 2014

I'll send a list mail tomorrow + get a phpcodesniffer ruleset up for review - was planning on doing that tonight but it's 00:40 and it's just taken me ages to test + deal with merge conflicts on this branch.

@grangeway grangeway deleted the grangeway:cs branch Jul 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment