Skip to content

Allows plugins to ask for input upon status change #55

Closed
wants to merge 1 commit into from

2 participants

@vincentsels

fixes http://www.mantisbt.org/bugs/view.php?id=14329
replaces pull request #54
hope this time the diff is shown correctly...

@dregad dregad referenced this pull request Jul 22, 2012
Closed

Fix for ticket 0013332 #35

@dregad
Mantis Bug Tracker member
dregad commented Jul 22, 2012

I took the liberty to edit your initial post to make the PR number a reference (i.e. added a #).
However, I'm not really sure this is a replacement for #35, which intends to fix ticket 13332 (strtotime issue with date format "d/m/Y") whereas this adds a new plugin event...

@vincentsels

My mistake - sorry for the confusion. This PR replaces 54; not 35, which I haven't made a new one for yet. Don't know what went wrong with PR 35. I'll try to get that fix onto the current head of the master-1.2.x and create a new PR.
(to avoid future confusion, is it possible to delete the reference to PR 35 ?)

@dregad
Mantis Bug Tracker member
dregad commented Jul 24, 2012

Not sure if and how to remove a PR reference. I can only edit comments.

@dregad
Mantis Bug Tracker member
dregad commented Aug 1, 2012

@vincentsels, I was about to merge this, but noticed while trying to port your changes to master branch, that what seems a very similar event already exists in 1.3. May I kindly ask you to review commit 5409ebc / related issue #10126, and let me know if they are one and the same ?

If that is indeed the case I would rather backport the change for consistency (although the event name in your commit is better, so I might adjust the master branch to match that anyway).

@vincentsels

That seems to be exactly the same indeed.

@dregad
Mantis Bug Tracker member
dregad commented Aug 7, 2012

Backported from master (aecee48) and event renamed (9db97b9).

@dregad dregad closed this Aug 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.