Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added user avatar to view_user_page, see issue #0016248 #573

Conversation

Projects
None yet
2 participants
@andersruneson
Copy link
Contributor

commented Feb 2, 2015

In case you still accept patches for the 1.2.x-series, here is one that adds avatar (if configured) to the view_user_page.

screenshot from 2015-02-02 20 18 03

@dregad

This comment has been minimized.

Copy link
Member

commented Feb 2, 2015

Thanks for your contribution.

In terms of design, IMO having the avatar to the left of the labels breaks the consistency of the UI, I think it would be better to have it on the right-hand side. Also, the title row ("User Information") no longer spans correctly.

That being said, since this is a new feature and not a bug fix, it should go in master and not in 1.2. Would you mind porting your branch ?

@andersruneson

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2015

My motivation for this PR is to maintain fewer patches in my own installation for every update to Mantis stable. Would you consider merging in 1.2 if I fix your comments?

As for master/1.3 I can port this as soon as I have an installation for testing.

@dregad

This comment has been minimized.

Copy link
Member

commented Feb 3, 2015

Would you consider merging in 1.2 if I fix your comments?

The change is quite harmless and limited in scope, so yes I would consider it.

@andersruneson

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2015

Updated branch.
screenshot from 2015-02-04 09 19 25

@dregad dregad closed this Apr 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.