Implement --browser-field option #139

Merged
merged 2 commits into from May 15, 2016

Conversation

Projects
None yet
2 participants
@hakatashi
Contributor

hakatashi commented Apr 28, 2016

This is follow-up of #136.

As specified in #136 (comment), I created fixtures to test against the case where the browser field of test's dependency is involved in the test code. It's located in test/fixture/browser-field.

@mantoni

This comment has been minimized.

Show comment
Hide comment
@mantoni

mantoni May 12, 2016

Owner

Thanks for the pull request and sorry for letting you wait. Nice change, nothing to complain about 🎈. Can you rebase the commits and sqash them down to one or two? Then I'll merge and cut a release.

For bonus points you could add the new option to the readme and the help.txt.

Owner

mantoni commented May 12, 2016

Thanks for the pull request and sorry for letting you wait. Nice change, nothing to complain about 🎈. Can you rebase the commits and sqash them down to one or two? Then I'll merge and cut a release.

For bonus points you could add the new option to the readme and the help.txt.

@hakatashi

This comment has been minimized.

Show comment
Hide comment
@hakatashi

hakatashi May 15, 2016

Contributor

@mantoni Everything is ready now 😉

Contributor

hakatashi commented May 15, 2016

@mantoni Everything is ready now 😉

@mantoni mantoni merged commit c65a6db into mantoni:master May 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mantoni

This comment has been minimized.

Show comment
Hide comment
@mantoni

mantoni May 15, 2016

Owner

Released in 2.18.0. Thank you!

Owner

mantoni commented May 15, 2016

Released in 2.18.0. Thank you!

@hakatashi hakatashi deleted the hakatashi:add-browser-field-option branch May 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment