Custom configuration for consumer and producer #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # embedded-kafka/src/main/scala/net/manub/embeddedkafka/EmbeddedKafkaConfig.scala
manub
reviewed
Mar 1, 2017
| import scala.language.postfixOps | ||
|
|
||
| class EmbeddedKafkaCustomConfigSpec extends EmbeddedKafkaSpecSupport with EmbeddedKafka { | ||
| val TWO_MEGABYTES = 2097152 |
Owner
There was a problem hiding this comment.
these should be probably be named TwoMegabytes and ThreeMegabytes as per http://docs.scala-lang.org/style/naming-conventions.html
manub
reviewed
Mar 1, 2017
| val THREE_MEGABYTES = 3145728 | ||
|
|
||
| "the custom config" should { | ||
| "should allow pass additional producer parameters" in { |
manub
reviewed
Mar 1, 2017
| } | ||
|
|
||
| def generateMessageOfLength(length: Int): String = Stream.continually(util.Random.nextPrintableChar) take length mkString | ||
| } No newline at end of file |
Owner
There was a problem hiding this comment.
newline please (at the end of file)
manub
requested changes
Mar 1, 2017
Owner
manub
left a comment
manub
left a comment
There was a problem hiding this comment.
Thanks for the effort! Please fix a couple of minor style issues and then I'll merge it.
Contributor
Author
|
Fixed |
Owner
|
Thanks! You were mentioning you need this on 0.8 branch? |
Contributor
Author
|
Sorry, I made a mistake. I thought about Kafka 0.9, but no branch here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
We need to test message flow with messages bigger than default 1MB.
I've prepared a pull request with additional custom producer and consumer configurations.
I also created a unit test for it and updated README with code example.
Can you take a look ?
Any comments welcome
In near future, I plan to merge it to 0.8 branch, because we need it on Spark 1.6
Regards