Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aesthetics: add space (or other punctuation) between title and container-title in CSL #218

Closed
slochower opened this issue May 4, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@slochower
Copy link
Collaborator

commented May 4, 2019

I think there should be a space between container-title and title, if there are no authors or publication. For example, this is how I see GitHub citations rendered:

image

image

The JSON returned from GitHub looks like:

  {
    "type": "webpage",
    "title": "Remove generics, add hydrogen radii, rename ffxml files by davidlmobley · Pull Request #101 · openforcefield/openforcefield",
    "container-title": "GitHub",
    "abstract": "This PR will:\n\n Remove generic atoms matching any element from smirnoff99Frosst so exceptions are raised if parameters are assigned to a molecule which contains an element we don't cover (osmiu...",
    "URL": "https://github.com/openforcefield/openforcefield/pull/101",
    "language": "en",
    "accessed": {
      "date-parts": [
        [
          "2019",
          5,
          4
        ]
      ]
    },
    "id": "cT3I9uDT"
  },
@slochower

This comment has been minimized.

Copy link
Collaborator Author

commented May 4, 2019

I think this maybe happens because there's only a group delimiter between author and venue, not title and venue, and if author is missing, perhaps this delimiter is skipped.

<group>
<text variable="title" font-weight="bold"/>
</group>
<group display="block">
<text macro="author"/>
</group>
<group delimiter=" ">
<text macro="venue" font-style="italic"/>
<date variable="issued" prefix="(" suffix=")">
<date-part name="year"/>
<date-part name="month" form="numeric-leading-zeros" prefix="-"/>
<date-part name="day" form="numeric-leading-zeros" prefix="-"/>
</date>
<text variable="URL"/>
</group>

@agitter

This comment has been minimized.

Copy link
Member

commented May 4, 2019

I agree this should be changed. @vincerubinetti is this the same issue that #158 fixes?

@slochower

This comment has been minimized.

Copy link
Collaborator Author

commented May 4, 2019

Ah, yes. Perhaps this will be fixed by #158 by setting a " " delimiter between all fields, I think.

@vincerubinetti

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

@agitter I believe so! cc @dhimmel for review of #158

@dhimmel

This comment has been minimized.

Copy link
Member

commented May 6, 2019

I think it is possible that dhimmel@12b4783 and #158 will both fix this issue. Let me open a PR for dhimmel@12b4783, which we have already included partially in greenelab/meta-review#216. The issue with changes to our CSL is that we don't have good tests. Therefore, I sometimes worry that when we fix one thing, we may break something else.

@dhimmel dhimmel closed this in #219 May 14, 2019

dhimmel added a commit that referenced this issue May 14, 2019

CSL author macro: substitute editor/venue
Merges #219

Ensures there is a newline between the title and venue,
when authors are missing.
Closes #218
Supersedes #158

Substitutes editors for authors when authors are missing.
Editors are labeled like "Sönke Bartling, Sascha Friesike (editors)".

dhimmel added a commit that referenced this issue May 14, 2019

CSL author macro: substitute editor/venue
This build is based on
5da1d32.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/manubot/rootstock/builds/111763307
https://travis-ci.com/manubot/rootstock/jobs/200071500

[ci skip]

The full commit message that triggered this build is copied below:

CSL author macro: substitute editor/venue

Merges #219

Ensures there is a newline between the title and venue,
when authors are missing.
Closes #218
Supersedes #158

Substitutes editors for authors when authors are missing.
Editors are labeled like "Sönke Bartling, Sascha Friesike (editors)".

dhimmel added a commit that referenced this issue May 14, 2019

CSL author macro: substitute editor/venue
This build is based on
5da1d32.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/manubot/rootstock/builds/111763307
https://travis-ci.com/manubot/rootstock/jobs/200071500

[ci skip]

The full commit message that triggered this build is copied below:

CSL author macro: substitute editor/venue

Merges #219

Ensures there is a newline between the title and venue,
when authors are missing.
Closes #218
Supersedes #158

Substitutes editors for authors when authors are missing.
Editors are labeled like "Sönke Bartling, Sascha Friesike (editors)".

slochower added a commit to slochower/smirnoff-host-guest-manuscript that referenced this issue May 15, 2019

Rootstock 2019 05 15 (#36)
* webpage.py: note to ignore error in versions checkout

Merges manubot/rootstock#211
Closes manubot/rootstock#183

* Use Athena to build PDF, if Docker installed

Merges manubot/rootstock#210
Closes manubot/rootstock#170

More information about Athena is available at
https://github.com/arachnys/athenapdf

Based on meta-review commit:
greenelab/meta-review@cffcfea

* Add meta review link to readme

Merges manubot/rootstock#217
Closes manubot/rootstock#216

* Increase shared memory of athenapdf container

Merges manubot/rootstock#220
Closes arachnys/athenapdf#195

Increase --shm-size from the default value of 64m to 1g when
running the athenapdf Docker image. Resolves athena issue:
`The renderer process has crashed`

Switch to using equal sign to separate Docker arguments
and values for consistency.
https://stackoverflow.com/q/50319060/4651668

* CSL author macro: substitute editor/venue

Merges manubot/rootstock#219

Ensures there is a newline between the title and venue,
when authors are missing.
Closes manubot/rootstock#218
Supersedes manubot/rootstock#158

Substitutes editors for authors when authors are missing.
Editors are labeled like "Sönke Bartling, Sascha Friesike (editors)".

slochower added a commit to slochower/smirnoff-host-guest-manuscript that referenced this issue May 15, 2019

Rootstock 2019 05 15 (#36)
This build is based on
d62afc4.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/slochower/smirnoff-host-guest-manuscript/builds/532938787
https://travis-ci.com/slochower/smirnoff-host-guest-manuscript/jobs/532938788

[ci skip]

The full commit message that triggered this build is copied below:

Rootstock 2019 05 15 (#36)

* webpage.py: note to ignore error in versions checkout

Merges manubot/rootstock#211
Closes manubot/rootstock#183

* Use Athena to build PDF, if Docker installed

Merges manubot/rootstock#210
Closes manubot/rootstock#170

More information about Athena is available at
https://github.com/arachnys/athenapdf

Based on meta-review commit:
greenelab/meta-review@cffcfea

* Add meta review link to readme

Merges manubot/rootstock#217
Closes manubot/rootstock#216

* Increase shared memory of athenapdf container

Merges manubot/rootstock#220
Closes arachnys/athenapdf#195

Increase --shm-size from the default value of 64m to 1g when
running the athenapdf Docker image. Resolves athena issue:
`The renderer process has crashed`

Switch to using equal sign to separate Docker arguments
and values for consistency.
https://stackoverflow.com/q/50319060/4651668

* CSL author macro: substitute editor/venue

Merges manubot/rootstock#219

Ensures there is a newline between the title and venue,
when authors are missing.
Closes manubot/rootstock#218
Supersedes manubot/rootstock#158

Substitutes editors for authors when authors are missing.
Editors are labeled like "Sönke Bartling, Sascha Friesike (editors)".

slochower added a commit to slochower/smirnoff-host-guest-manuscript that referenced this issue May 15, 2019

Rootstock 2019 05 15 (#36)
This build is based on
d62afc4.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/slochower/smirnoff-host-guest-manuscript/builds/532938787
https://travis-ci.com/slochower/smirnoff-host-guest-manuscript/jobs/532938788

[ci skip]

The full commit message that triggered this build is copied below:

Rootstock 2019 05 15 (#36)

* webpage.py: note to ignore error in versions checkout

Merges manubot/rootstock#211
Closes manubot/rootstock#183

* Use Athena to build PDF, if Docker installed

Merges manubot/rootstock#210
Closes manubot/rootstock#170

More information about Athena is available at
https://github.com/arachnys/athenapdf

Based on meta-review commit:
greenelab/meta-review@cffcfea

* Add meta review link to readme

Merges manubot/rootstock#217
Closes manubot/rootstock#216

* Increase shared memory of athenapdf container

Merges manubot/rootstock#220
Closes arachnys/athenapdf#195

Increase --shm-size from the default value of 64m to 1g when
running the athenapdf Docker image. Resolves athena issue:
`The renderer process has crashed`

Switch to using equal sign to separate Docker arguments
and values for consistency.
https://stackoverflow.com/q/50319060/4651668

* CSL author macro: substitute editor/venue

Merges manubot/rootstock#219

Ensures there is a newline between the title and venue,
when authors are missing.
Closes manubot/rootstock#218
Supersedes manubot/rootstock#158

Substitutes editors for authors when authors are missing.
Editors are labeled like "Sönke Bartling, Sascha Friesike (editors)".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.