Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI workflow cannot create PR #492

Closed
SilasK opened this issue Apr 13, 2023 · 3 comments · Fixed by #493
Closed

AI workflow cannot create PR #492

SilasK opened this issue Apr 13, 2023 · 3 comments · Fixed by #493

Comments

@SilasK
Copy link

SilasK commented Apr 13, 2023

I encountered problems in the ai revision workflow, not in the ai revision but in the pull request afterward.

  • I gave actions rights to create PRs. But it seems we need to give write access to actions.
    I suggest clarifying this in the documentation.
  • For me, draft PRs were not allowed.

I don't know why this happened, maybe because I had a private repo?

@agitter
Copy link
Member

agitter commented Apr 14, 2023

Thanks for the suggestion. If these permissions aren't always enabled, I agree we should document them.

To confirm, is this the setting you needed to change?
Actions:
image

Was there a separate setting you needed to change to enable draft pull requests? These docs suggest they may be tied to the write permissions.

@SilasK
Copy link
Author

SilasK commented Apr 14, 2023

Yes, I needed to change this settings.

I set draft to true in the workflow.yaml

Because I could not figure out how to allow draft PRs.

@dhimmel
Copy link
Member

dhimmel commented Apr 14, 2023

We should be able to set the permissions explicitly in ai-revision.yaml, such that default workflow permissions are overridden. We do this for manubot.yaml:

permissions:
contents: write

agitter added a commit that referenced this issue Apr 23, 2023
merges #493
closes #492

* Set write permissions in AI workflow
* Add pull-requests write permissions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants