Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta review link to readme #217

Merged
merged 3 commits into from May 1, 2019

Conversation

Projects
None yet
2 participants
@agitter
Copy link
Member

commented Apr 28, 2019

Closes #216

I'm leaving the full citation in USAGE.md to help minimize confusion about what to cite in downstream manuscript instances.

@agitter agitter requested a review from dhimmel Apr 28, 2019

@dhimmel
Copy link
Member

left a comment

One suggestion, but otherwise looks good to me.

README.md Outdated
@@ -19,6 +19,7 @@ Actual manuscript instances will clone this repository (see [`SETUP.md`](SETUP.m

Manubot is a system for writing scholarly manuscripts via GitHub.
Manubot automates citations and references, versions manuscripts using git, and enables collaborative writing via GitHub.
An [overview manuscript](https://greenelab.github.io/meta-review/) presents the benefits of collaborative writing with Manubot and its unique features.

This comment has been minimized.

Copy link
@dhimmel

dhimmel Apr 30, 2019

Member

Can we add a title to the link of "Open collaborative writing with Manubot"

This comment has been minimized.

Copy link
@agitter

agitter Apr 30, 2019

Author Member

👍 added in 9f7c0d2

@agitter agitter merged commit 8d74236 into manubot:master May 1, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@agitter agitter deleted the agitter:meta-review-link branch May 1, 2019

dhimmel pushed a commit that referenced this pull request May 1, 2019

Add meta review link to readme
This build is based on
8d74236.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/manubot/rootstock/builds/110208092
https://travis-ci.com/manubot/rootstock/jobs/196821532

[ci skip]

The full commit message that triggered this build is copied below:

Add meta review link to readme

Merges #217
Closes #216

dhimmel pushed a commit that referenced this pull request May 1, 2019

Add meta review link to readme
This build is based on
8d74236.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/manubot/rootstock/builds/110208092
https://travis-ci.com/manubot/rootstock/jobs/196821532

[ci skip]

The full commit message that triggered this build is copied below:

Add meta review link to readme

Merges #217
Closes #216

slochower added a commit to slochower/smirnoff-host-guest-manuscript that referenced this pull request May 15, 2019

Rootstock 2019 05 15 (#36)
* webpage.py: note to ignore error in versions checkout

Merges manubot/rootstock#211
Closes manubot/rootstock#183

* Use Athena to build PDF, if Docker installed

Merges manubot/rootstock#210
Closes manubot/rootstock#170

More information about Athena is available at
https://github.com/arachnys/athenapdf

Based on meta-review commit:
greenelab/meta-review@cffcfea

* Add meta review link to readme

Merges manubot/rootstock#217
Closes manubot/rootstock#216

* Increase shared memory of athenapdf container

Merges manubot/rootstock#220
Closes arachnys/athenapdf#195

Increase --shm-size from the default value of 64m to 1g when
running the athenapdf Docker image. Resolves athena issue:
`The renderer process has crashed`

Switch to using equal sign to separate Docker arguments
and values for consistency.
https://stackoverflow.com/q/50319060/4651668

* CSL author macro: substitute editor/venue

Merges manubot/rootstock#219

Ensures there is a newline between the title and venue,
when authors are missing.
Closes manubot/rootstock#218
Supersedes manubot/rootstock#158

Substitutes editors for authors when authors are missing.
Editors are labeled like "Sönke Bartling, Sascha Friesike (editors)".

slochower added a commit to slochower/smirnoff-host-guest-manuscript that referenced this pull request May 15, 2019

Rootstock 2019 05 15 (#36)
This build is based on
d62afc4.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/slochower/smirnoff-host-guest-manuscript/builds/532938787
https://travis-ci.com/slochower/smirnoff-host-guest-manuscript/jobs/532938788

[ci skip]

The full commit message that triggered this build is copied below:

Rootstock 2019 05 15 (#36)

* webpage.py: note to ignore error in versions checkout

Merges manubot/rootstock#211
Closes manubot/rootstock#183

* Use Athena to build PDF, if Docker installed

Merges manubot/rootstock#210
Closes manubot/rootstock#170

More information about Athena is available at
https://github.com/arachnys/athenapdf

Based on meta-review commit:
greenelab/meta-review@cffcfea

* Add meta review link to readme

Merges manubot/rootstock#217
Closes manubot/rootstock#216

* Increase shared memory of athenapdf container

Merges manubot/rootstock#220
Closes arachnys/athenapdf#195

Increase --shm-size from the default value of 64m to 1g when
running the athenapdf Docker image. Resolves athena issue:
`The renderer process has crashed`

Switch to using equal sign to separate Docker arguments
and values for consistency.
https://stackoverflow.com/q/50319060/4651668

* CSL author macro: substitute editor/venue

Merges manubot/rootstock#219

Ensures there is a newline between the title and venue,
when authors are missing.
Closes manubot/rootstock#218
Supersedes manubot/rootstock#158

Substitutes editors for authors when authors are missing.
Editors are labeled like "Sönke Bartling, Sascha Friesike (editors)".

slochower added a commit to slochower/smirnoff-host-guest-manuscript that referenced this pull request May 15, 2019

Rootstock 2019 05 15 (#36)
This build is based on
d62afc4.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/slochower/smirnoff-host-guest-manuscript/builds/532938787
https://travis-ci.com/slochower/smirnoff-host-guest-manuscript/jobs/532938788

[ci skip]

The full commit message that triggered this build is copied below:

Rootstock 2019 05 15 (#36)

* webpage.py: note to ignore error in versions checkout

Merges manubot/rootstock#211
Closes manubot/rootstock#183

* Use Athena to build PDF, if Docker installed

Merges manubot/rootstock#210
Closes manubot/rootstock#170

More information about Athena is available at
https://github.com/arachnys/athenapdf

Based on meta-review commit:
greenelab/meta-review@cffcfea

* Add meta review link to readme

Merges manubot/rootstock#217
Closes manubot/rootstock#216

* Increase shared memory of athenapdf container

Merges manubot/rootstock#220
Closes arachnys/athenapdf#195

Increase --shm-size from the default value of 64m to 1g when
running the athenapdf Docker image. Resolves athena issue:
`The renderer process has crashed`

Switch to using equal sign to separate Docker arguments
and values for consistency.
https://stackoverflow.com/q/50319060/4651668

* CSL author macro: substitute editor/venue

Merges manubot/rootstock#219

Ensures there is a newline between the title and venue,
when authors are missing.
Closes manubot/rootstock#218
Supersedes manubot/rootstock#158

Substitutes editors for authors when authors are missing.
Editors are labeled like "Sönke Bartling, Sascha Friesike (editors)".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.