Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual reference example #5

Merged
merged 5 commits into from Jul 5, 2017

Conversation

Projects
None yet
2 participants
@agitter
Copy link
Member

commented Jul 3, 2017

No description provided.

@dhimmel

dhimmel approved these changes Jul 5, 2017

Copy link
Member

left a comment

This is a flawless PR!

I'm thinking we should also move the citation format info out of CONTRIBUTING to README.

[`manual-references.json`](manual-references.json) contains manually managed
reference data, which overrides the automatically extracted data.

## Reference overrides

This comment has been minimized.

Copy link
@dhimmel

dhimmel Jul 5, 2017

Member

Wow @agitter you rock at writing docs!

@dhimmel dhimmel merged commit 439bf03 into manubot:master Jul 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

dhimmel pushed a commit that referenced this pull request Jul 5, 2017

Manual reference example (#5)
This build is based on
439bf03.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/manubot-rootstock/builds/250407551
https://travis-ci.org/greenelab/manubot-rootstock/jobs/250407552

[ci skip]

The full commit message that triggered this build is copied below:

Manual reference example (#5)

Closes #3

* URL reference for manual reference example
* Add intructions for manual references
* Fix relative link
* Add manual reference example
* Rephrasing

dhimmel pushed a commit that referenced this pull request Jul 5, 2017

Manual reference example (#5)
This build is based on
439bf03.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/manubot-rootstock/builds/250407551
https://travis-ci.org/greenelab/manubot-rootstock/jobs/250407552

[ci skip]

The full commit message that triggered this build is copied below:

Manual reference example (#5)

Closes #3

* URL reference for manual reference example
* Add intructions for manual references
* Fix relative link
* Add manual reference example
* Rephrasing

@agitter agitter deleted the agitter:manual-references branch Jul 5, 2017

@agitter

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2017

I'm thinking we should also move the citation format info out of CONTRIBUTING to README.

I agree that makes sense. I'm also opening a new issue with more thoughts on usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.