Allow multiple consecutive slashes in paths (but see discussion) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure, AFAICT there doesn't seem to be a clear way on how other tools to handle this. For now I think disallowing a trailing "/" is the safe approach. |
Property404
force-pushed
the
Property404/multiple-slashes
branch
from
ee9a2b6
to
8db3519
Compare
|
LGTM - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #42
Discussion:
So, I'm unsure of how a slash at the end should be handled. On one hand, it seems weird that you can refer to a file like
dir/file.txt/, but you can already dodir/file.txt/.Both seem a bit weird, I don't know how you would solve that. I guess for consistencies sake, you should allow both
Thoughts?