Better feature test #1

Closed
mathiasbynens opened this Issue Aug 8, 2011 · 4 comments

Comments

Projects
None yet
2 participants
@mathiasbynens

To check for native <details> support you may want to use a more robust feature test. WebKit had implemented the IDL attributes (so 'open' in document.createElement('details') === true) long before it actually supported <details>.

For a more robust solution, see http://mathiasbynens.be/notes/html5-details-jquery and especially http://mathiasbynens.be/notes/html5-details-jquery#comment-35

@manuelbieh

This comment has been minimized.

Show comment
Hide comment
@manuelbieh

manuelbieh Aug 8, 2011

Owner

Oh, thank you for this information!

Owner

manuelbieh commented Aug 8, 2011

Oh, thank you for this information!

@mathiasbynens

This comment has been minimized.

Show comment
Hide comment
@mathiasbynens

mathiasbynens Aug 8, 2011

Did you know about my polyfill before you started yours? Just wondering if there was anything in particular you didn’t like about my version. I appreciate any feedback!

Did you know about my polyfill before you started yours? Just wondering if there was anything in particular you didn’t like about my version. I appreciate any feedback!

@manuelbieh

This comment has been minimized.

Show comment
Hide comment
@manuelbieh

manuelbieh Aug 8, 2011

Owner

No. I just didn't know until I was almost done. If I had seen it before I had probably never created my own polyfill ;)

Now it's my goal to make it not-jQuery-dependend.

Owner

manuelbieh commented Aug 8, 2011

No. I just didn't know until I was almost done. If I had seen it before I had probably never created my own polyfill ;)

Now it's my goal to make it not-jQuery-dependend.

@manuelbieh manuelbieh reopened this Nov 22, 2011

@manuelbieh manuelbieh closed this Nov 22, 2011

@mathiasbynens

This comment has been minimized.

Show comment
Hide comment
@mathiasbynens

mathiasbynens Jul 6, 2012

Could you add a comment with a link to http://mathiasbynens.be/notes/html5-details-jquery above the feature test?

Could you add a comment with a link to http://mathiasbynens.be/notes/html5-details-jquery above the feature test?

manuelbieh added a commit that referenced this issue Jul 12, 2012

@manuelbieh manuelbieh reopened this Jul 12, 2012

@manuelbieh manuelbieh closed this Jul 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment