Grammar check. #19

Merged
merged 4 commits into from Jun 28, 2012

Conversation

Projects
None yet
2 participants
Contributor

gurjeet commented May 20, 2012

I think "call the corresponding function" sounds better that "call the according function"

BTW, thank you for the book :)

@@ -2551,7 +2551,7 @@
<p>
This will make HTTP requests to <a href="http://localhost:8888/start" rel="nofollow">http://localhost:8888/start</a>
- take at least 10 seconds, but requests to <a href="http://localhost:8888/upload" rel="nofollow">http://localhost:8888/upload</a>
+ take at most 10 seconds, but requests to <a href="http://localhost:8888/upload" rel="nofollow">http://localhost:8888/upload</a>
@manuelkiessling

manuelkiessling Jun 23, 2012

Owner

I'm pretty sure that "at least" makes more sense here, because the request will take the 10 "sleep" seconds and then some, due to the processing overhead that comes with every request (although this is very small, of course).

"At most" sounds like it could sometimes take only 8 seconds, which isn't the case.

@gurjeet

gurjeet Jun 23, 2012

Contributor

I think you are looking at wrong piece of code. I don't see any sleep() calls in /start handler that precedes this statement. The exec("find /") is executed with a timeout of 10000, which means that command can take at most 10 seconds, and no more.

function start(response) {
console.log("Request handler 'start' was called.");

exec("find /",
{ timeout: 10000, maxBuffer: 20000*1024 },
function (error, stdout, stderr) {
response.writeHead(200, {"Content-Type": "text/plain"});
response.write(stdout);
response.end();
});
}

@manuelkiessling

manuelkiessling Jun 28, 2012

Owner

Oh, my bad, I'm sorry!

manuelkiessling added a commit that referenced this pull request Jun 28, 2012

@manuelkiessling manuelkiessling merged commit a482066 into manuelkiessling:master Jun 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment