New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max-age attribute correctly from constructor #3

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@jjatria

jjatria commented Apr 27, 2018

This patch (largely the same as leejo/CGI.pm@7d46fae) fixes an issue with the handling of the -max-age parameter to the constructor, and resolves RT #124006.

This pull request courtesy of the PRC~

Set max-age attribute correctly from constructor
From the equivalent commit in CGI:

> Previously the value from the -expires argument was
> being used, meaning it was not possible to pass *only* the -max-age
> argument and have this set. this also means that the values for the
> -max-age and -expires arguments can be different, should you want to
> do something like that
>
> update tests to reflect above change and increase coverage for the
> -max-age constructor argument / max_age method. also update perldoc
> adding missing documentation for the max_age method

@manwar manwar merged commit a9ccde7 into manwar:master Oct 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

manwar added a commit that referenced this pull request Oct 4, 2018

@manwar

This comment has been minimized.

Owner

manwar commented Oct 4, 2018

Thanks @jjatria

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment