New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum Perl version (PRC) #2

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@jjatria
Contributor

jjatria commented Feb 19, 2017

Add the minimum required Perl version to Makefile.PL, to get rid of the CPANTS warning.

This is a PRC contribution.

@manwar

This comment has been minimized.

Show comment
Hide comment
@manwar

manwar Mar 6, 2017

Owner

Hi @jjatria

Thanks for the PR, much appreciated.
Can you please resolve the failed checks?

Apology for late response, I recently adopted the module and going through all PRs.

Many Thanks.
Best Regards,
Mohammad S Anwar

Owner

manwar commented Mar 6, 2017

Hi @jjatria

Thanks for the PR, much appreciated.
Can you please resolve the failed checks?

Apology for late response, I recently adopted the module and going through all PRs.

Many Thanks.
Best Regards,
Mohammad S Anwar

@jjatria

This comment has been minimized.

Show comment
Hide comment
@jjatria

jjatria Mar 6, 2017

Contributor

I'd love to, but I don't quite know what is failing, to be honest.

The Travis report says that the failure is with Perl 5.12, but running the tests on my machine with Perl 5.12.5 shows no errors. The Travis log shows no output either, so it looks like a stalled build. What makes it stall, however, is beyond me: the changes in this PR are minimal.

Do you have any ideas?

Contributor

jjatria commented Mar 6, 2017

I'd love to, but I don't quite know what is failing, to be honest.

The Travis report says that the failure is with Perl 5.12, but running the tests on my machine with Perl 5.12.5 shows no errors. The Travis log shows no output either, so it looks like a stalled build. What makes it stall, however, is beyond me: the changes in this PR are minimal.

Do you have any ideas?

@manwar

This comment has been minimized.

Show comment
Hide comment
@manwar

manwar Jan 25, 2018

Owner

This was manually done on Aug 7 11:19:14 2017
Commit Id: c27ebd9

Apologies for the delay.

Owner

manwar commented Jan 25, 2018

This was manually done on Aug 7 11:19:14 2017
Commit Id: c27ebd9

Apologies for the delay.

@manwar manwar closed this Jan 25, 2018

@jjatria jjatria deleted the jjatria:min-perl-ver branch Apr 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment