Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Test Reports #11
I received this dist in this month's Pull Request Challenge. It seems like a pretty clean dist with not a lot of fixes to jump into other than some minor testing setup changes. Overall, this is a pretty trivial change that should hopefully make testing a bit easier and provide reports from users and smoke testers when something blows up.
No actual code changes were made.
A few of the test files were moved into a more common
A new test file,
Thanks for your contribution, much appreciated :-)
Please don't get me wrong, I appreciate your effort and time. However I am still not fully convinced about (3 and 4).
Feb 12, 2018
1 check passed
added a commit
this pull request
Feb 12, 2018
Oh, wow. Sorry about that @manwar. I never saw your reply to this PR.
On number 3: I'm more a fan of hiding release and author tests off into xt/ that way we don't have to add things like
On number 4: .gitignore solely helps to not check in new files errantly. This is not of a particular large issue with me, but some devs I've worked with tend to do something akin to:
Such a process doesn't catch me because I tend to commit and comment specifically on what I want to check in via
Again, sorry I didn't respond to your questions. I either completely missed the notification (likely) or didn't get it somehow.
Hope all's well!