New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cpants issues #14

Merged
merged 3 commits into from Jan 2, 2017

Conversation

Projects
None yet
2 participants
@manwar
Owner

manwar commented Jan 2, 2017

Hi Gabor,

As part of PRC 2017, this is my Jan 2017 pull request.
Please review the PR.
It try to address issues raised by CPANTS. Also cpantester failed report.

Many Thanks.
Best Regards,
Mohammad S Anwar

@szabgab

This comment has been minimized.

Show comment
Hide comment
@szabgab

szabgab Jan 2, 2017

Collaborator

Can I just pass the whole distribution to you? Would that still count in the PRC?

Collaborator

szabgab commented Jan 2, 2017

Can I just pass the whole distribution to you? Would that still count in the PRC?

@manwar

This comment has been minimized.

Show comment
Hide comment
@manwar

manwar Jan 2, 2017

Owner

Hi Gabor,

I am not sure, whether it still counts or not, honestly speaking.
However you can merge my pull request if you are happy with my proposed changes.
And then you can transfer the distribution, if you like.
I will never say "No" to such request, you know my weakness.

Best Regards,
Mohammad S Anwar

Owner

manwar commented Jan 2, 2017

Hi Gabor,

I am not sure, whether it still counts or not, honestly speaking.
However you can merge my pull request if you are happy with my proposed changes.
And then you can transfer the distribution, if you like.
I will never say "No" to such request, you know my weakness.

Best Regards,
Mohammad S Anwar

@szabgab szabgab merged commit d659942 into manwar:master Jan 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@szabgab

This comment has been minimized.

Show comment
Hide comment
@szabgab

szabgab Jan 2, 2017

Collaborator

great. merged. Please remove the fork you have in GitHub and then I'll transfer the repo.

Collaborator

szabgab commented Jan 2, 2017

great. merged. Please remove the fork you have in GitHub and then I'll transfer the repo.

@manwar

This comment has been minimized.

Show comment
Hide comment
@manwar

manwar Jan 2, 2017

Owner

Removed the fork.
Thanks

Owner

manwar commented Jan 2, 2017

Removed the fork.
Thanks

manwar added a commit that referenced this pull request Oct 26, 2017

- [2017-10-26]: Added META.yml back to MANIFEST file.
- [2017-10-26]: Tidied up .gitignore, Changes and MANIFEST file.
- [2017-10-26]: Merge pull request #15 from kiwiroy/rt-76160
- [2017-01-02]: Merge pull request #14 from manwar/fix-cpants-issues
- [2016-10-04]: Merge pull request #13 from pauloscustodio/pscust_1
- [2015-10-18]: Merge pull request #12 from nichtich/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment