New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support queries for intersections #349

Open
sbma44 opened this Issue Oct 15, 2015 · 7 comments

Comments

Projects
None yet
5 participants
@sbma44
Member

sbma44 commented Oct 15, 2015

e.g. "5th & Main St"

@sbma44 sbma44 added the enhancement label Oct 15, 2015

@twbell

This comment has been minimized.

twbell commented Oct 15, 2015

This convention is employed only in a very select number of countries: US is P1, any others P2. It is used widely enough in the US that it merits serious consideration (however naff we think it may be in an addresspoint world).

@bennlich

This comment has been minimized.

bennlich commented Feb 18, 2017

Currently working with a dataset of US intersections. Wondering if there's a way around this, but thinking I'll have to use a different geocoding API.

@KaiBot3000

This comment has been minimized.

Contributor

KaiBot3000 commented Feb 20, 2017

Hi @bennlich, this is a feature that we'd love to have and have started work on, but it isn't a high priority at the moment. We'll happily accept a pull request implementing it!

@bennlich

This comment has been minimized.

bennlich commented Feb 22, 2017

@KaiBot3000 kk, thanks for the reply!

Not sure if I have the time/ability to really dive into this, but assuming I did, where'd be a good place to start reading the code?

Is the strategy to identify "5th & Main St" as a special kind of query and take it down its own code path, looking for an intersection of two polylines?

@andrewharvey

This comment has been minimized.

Contributor

andrewharvey commented Feb 22, 2017

You might be able to implement it client side too, splitting the query into two queries "5th Street" then "Main Street", however for this you'd want the result to return a street with a LineString geometry, rather than a point in the centroid of the street.

@KaiBot3000

This comment has been minimized.

Contributor

KaiBot3000 commented Feb 22, 2017

Hey @bennlich that sounds like a great approach to try. Carmen doesn't return full geometries on purpose; at Mapbox we're often working with proprietary datasets that we don't want to return in responses.

@KaiBot3000

This comment has been minimized.

Contributor

KaiBot3000 commented Feb 22, 2017

@bennlich I've put in some work on this quest already; feel free to check it out over in the [crossnodes] and [cross-street] branches. At the very least you'll be able to use the failing test cases. It's been a while since I've touched either of those branches, but let me know if you run into any issues or have questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment