Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if cover scoredist is score before treating it like its an encoded score #907

Closed
wants to merge 1 commit into from

Conversation

@Nmargolis
Copy link
Contributor

Nmargolis commented Nov 5, 2019

Context

Currently, if a cover's scoredist is <7, the scoredist gets treated as if it were the same as the score, which gets encoded as a value between 1 and 7 on a log scale. The scoredist is then "decoded" based on the scorefactor of the index. The scoredist is the same as the score in many cases, for example, when there is no proximity option.

It's possible for a scoredist that does take distance from a proximity point into account as part of it's scoredist to have a scoredist of <7. When it's treated the same as the score, it often gets "decoded" to end up as 1. This hides relevant differences in features that have low scores but some differentiation in distance from a point.

This is an attempt to preserve the original scoredist if the scoredist is not equal to the score, instead of guessing based on whether the scoredist is <7.

Summary of Changes

  • Only decode the scoredist if it is not the same as the score

Next Steps

  • Evaluate whether this is the correct approach for scoredists based on scores that have been encoded on the log scale

cc @mapbox/search

@Nmargolis Nmargolis force-pushed the scoredist-decode-fix branch from b26b9e2 to b377581 Nov 7, 2019
@Nmargolis

This comment has been minimized.

Copy link
Contributor Author

Nmargolis commented Nov 20, 2019

Closing in favor of #911

@Nmargolis Nmargolis closed this Nov 20, 2019
@Nmargolis Nmargolis deleted the scoredist-decode-fix branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.