Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

marker symbolizer, nested classes are ignored #65

Closed
ajashton opened this Issue · 6 comments

3 participants

@ajashton
Owner

I have a map with 2 point layers of the same datasource

  • #strikes-fill.strike.fill
  • #strikes-outline.strike.outline

Carto ignores the two nested class styles here (this is the full stylesheet):

.strikes {
  marker-fill:lighten(#ff194f,10);
  marker-line-color:darken(#ff194f,10);
  marker-opacity:0;
  marker-line-opacity:0;
  marker-allow-overlap:true;
  marker-width:1;
  .fill { marker-opacity:1; }
  .outline { marker-line-opacity:1; }
}
@tmcw
Owner

Does Carto ever recognize bare nested styles? I'm starting to think that this isn't valid, and has no relationship with markers or anything about the code - this is just currently unsupported.

@tmcw
Owner

Clearing milestone - this is currently unsupported behavior. We should support it, but this isn't a bug.

@Mr0grog

Would you please remove the examples in the README that show this if it's unsupported behavior? I just spent quite a while digging through the code to figure out why the examples weren't working and only afterwards saw this bug :(

Specifically, both the examples under "Nested Styles" don't work because of this issue!

(Also, the issue appears to be in tree.Ruleset#flatten(), where the result of merging parent and child filters, attachment, and zoom are checked for validity, but differences in elements are not checked and thus these rulesets get dropped).

@tmcw
Owner

@Mr0grog sorry this has dropped from my radar. I'll take a look at it when I get back to DC - I'd rather fix the code than redact the readme.

@Mr0grog

Awesome, thanks!

@tmcw
Owner

Fixed in #201

@tmcw tmcw closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.