Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust log groups, stream names #128

Closed
rclark opened this issue Feb 23, 2017 · 6 comments
Closed

Adjust log groups, stream names #128

rclark opened this issue Feb 23, 2017 · 6 comments

Comments

@rclark
Copy link
Contributor

rclark commented Feb 23, 2017

We want to get gitsha's out of our log group names, so that log groups persist between deploys. Will still want the gitsha involved in the mix, so later on we can deduce what version any set of logs came from.

  1. Remove the serviceVersion from the log group's name.

  2. Change the stream prefix so that it includes the gitsha.

cc @mapsam @yhahn

@GretaCB
Copy link

GretaCB commented Feb 23, 2017

Happy to lend a hand here, esp as I learn more about metric-ifying

@mapsam
Copy link
Member

mapsam commented Feb 23, 2017

@rclark do we need to also remove the options.serviceVersion from the LogGroupName of the Logs::LogGroup?

@rclark
Copy link
Contributor Author

rclark commented Feb 23, 2017

Yes! In fact, here were I originally linked we should probably be using a cf.ref or cf.getAtt to grab the log group's name instead of repeating the same thing twice.

@mapsam
Copy link
Member

mapsam commented Feb 23, 2017

using a cf.ref

Good idea, on it.

Seeing awslogs-stream-prefix in two places as well, for the worker and watcher. Same thing?

@rclark
Copy link
Contributor Author

rclark commented Feb 23, 2017

Yes please!

@mapsam
Copy link
Member

mapsam commented Aug 2, 2017

@rclark can this be closed now that #129 has been merged?

@rclark rclark closed this as completed Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants