Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off by one error in v8logToStacks #8

Open
jlfwong opened this issue Jul 20, 2018 · 1 comment
Open

Off by one error in v8logToStacks #8

jlfwong opened this issue Jul 20, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@jlfwong
Copy link

jlfwong commented Jul 20, 2018

I think this:

flamebearer/index.js

Lines 72 to 73 in a8d4d5c

for (let i = tick.s.length; i >= 0; i -= 2) {
const code = log.code[tick.s[i]];

should be i = tick.s.length - 1, otherwise this is going to consistently access something out of bounds in the tick.s array. Possibly you want it to be tick.s.length - 2 in order to retain alignment with the alternation between C++ and JavaScript stacks?

Thanks for writing this, by the way!

I'm using this as reference for importing v8 logs into speedscope (https://github.com/jlfwong/speedscope)

@mourner mourner added the bug Something isn't working label Aug 29, 2018
@mourner
Copy link
Member

mourner commented Aug 29, 2018

@jlfwong thanks a lot for Speedscope BTW, it's fantastic! I should probably deprecate this project in favor of yours — I wasn't aware of it when I started working on Flamebearer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants