You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
should be i = tick.s.length - 1, otherwise this is going to consistently access something out of bounds in the tick.s array. Possibly you want it to be tick.s.length - 2 in order to retain alignment with the alternation between C++ and JavaScript stacks?
@jlfwong thanks a lot for Speedscope BTW, it's fantastic! I should probably deprecate this project in favor of yours — I wasn't aware of it when I started working on Flamebearer :)
I think this:
flamebearer/index.js
Lines 72 to 73 in a8d4d5c
should be
i = tick.s.length - 1
, otherwise this is going to consistently access something out of bounds in thetick.s
array. Possibly you want it to betick.s.length - 2
in order to retain alignment with the alternation between C++ and JavaScript stacks?Thanks for writing this, by the way!
I'm using this as reference for importing v8 logs into speedscope (https://github.com/jlfwong/speedscope)
The text was updated successfully, but these errors were encountered: