Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Float zooms #15
@TeaSeaLancs The failing test was triggered for me when developing with NodeJS 8.
I originally wrote that test, and the float precision was unbounded. I guess NodeJS 8+ handles floats differently?
At any rate, I fixed this in #18, by rounding the coordinates in the test to 8 decimal places, which roughly equates to 1mm accuracy in much of the world.
If you rebase your branch off the latest
@mapsam helped me out last time, so he might know if any Mapbox people want to review before merge.
The code LGTM. It's hard to make readable tests for this maths stuff, but if the past test suite is still passing, and your new stuff is handling float zooms, then it should be sweet.