Explicit #13

Merged
merged 2 commits into from Jan 12, 2017

Projects

None yet

2 participants

@tmcw
Member
tmcw commented Jan 11, 2017

cc @DenisCarriere - this divides geojson-merge into two methods - one for streaming merging and the other for sync merging, and documents them separately and explicitly. It'd be a v1. Totally open to cleverer/more concise method names, I'm kind of lacking the imagination right now.

@DenisCarriere
Contributor

@tmcw Looks great as a v1, I'll go over it and add the Typescript definition and anything else that I added in that last PR.

Thanks for the CC (I feel important now 🥇 )

@DenisCarriere
Contributor

@tmcw Oh by the way, I can't merge this 👍

@tmcw tmcw merged commit 921556b into master Jan 12, 2017

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details
@tmcw tmcw deleted the explicit branch Jan 12, 2017
@DenisCarriere
Contributor
DenisCarriere commented Jan 12, 2017 edited

@tmcw As for clever/simplistic function names, since the module has two exported functions we can give the mergeFeatureCollectionStream function a very simple name since it will be imported with an already explicit import name.

Example

import geojsonMerge from '@mapbox/geojson-merge'

geojsonMerge.merge(<Features>)
geojsonMerge.stream(<Strings>)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment