New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WKX (WKT/WKB) support #557

Merged
merged 6 commits into from Mar 14, 2017

Conversation

Projects
None yet
2 participants
@lokkju
Contributor

lokkju commented Mar 14, 2017

This small change adds three menu items to the Meta menu, allowing the import and conversion of WKT strings, hex encoded WKB strings, and base64 encoded WKB strings. It cleanly adds the basic features requested by issue #232, without dealing with file format issues.

The added libraries, WKX and Buffer, are both MIT licensed

Show outdated Hide outdated package.json Outdated
Show outdated Hide outdated src/lib/meta.js Outdated
zoomextent(context);
} catch(e) {
console.error(e)
alert('Sorry, we were unable to decode that Base64 encoded WKX data');

This comment has been minimized.

@tmcw

tmcw Mar 14, 2017

Contributor

Says Base64 encoded here, should say Hex encoded.

@tmcw

tmcw Mar 14, 2017

Contributor

Says Base64 encoded here, should say Hex encoded.

This comment has been minimized.

@lokkju

lokkju Mar 14, 2017

Contributor

Think you put your comment in the wrong place. This block is base64; hex is a different block, and did need fixed. it now is.

@lokkju

lokkju Mar 14, 2017

Contributor

Think you put your comment in the wrong place. This block is base64; hex is a different block, and did need fixed. it now is.

Show outdated Hide outdated README.md Outdated
@tmcw

tmcw approved these changes Mar 14, 2017

@tmcw

This comment has been minimized.

Show comment
Hide comment
@tmcw

tmcw Mar 14, 2017

Contributor

Thanks!

Contributor

tmcw commented Mar 14, 2017

Thanks!

@tmcw tmcw merged commit bcebd54 into mapbox:gh-pages Mar 14, 2017

@lokkju lokkju deleted the lokkju:wkx_support branch Mar 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment