Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for every example #333

Open
friedbunny opened this issue Aug 7, 2019 · 0 comments
Open

Add tests for every example #333

friedbunny opened this issue Aug 7, 2019 · 0 comments
Labels
meta Issues related to the inner workings of this project. tests

Comments

@friedbunny
Copy link
Contributor

friedbunny commented Aug 7, 2019 •
edited

We currently only have tests that use XCUITest to run through every example, but this 1. does nothing to check correctness, and 2. is quite slow.

We should have goals to:

  1. Check that every example does what we intend.
  2. Make the tests runnable individually.
  3. Add tests with every new example as a requirement before merging.
  4. Prioritize reliability — failures must be meaningful and addressed immediately.

Thoughts

  • We should investigate other UI testing libraries, like KIF and earlgrey.
  • If tests are made faster and more reliable, we can run them on more simulators.

/cc @mapbox/maps-ios
@captainbarbosa captainbarbosa added the meta Issues related to the inner workings of this project. label Sep 18, 2019
@friedbunny friedbunny mentioned this issue Sep 20, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues related to the inner workings of this project. tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@friedbunny @captainbarbosa