Remove DirectionsResult.routeIdentifier property

[1ec5]

#406 moved the UUID from each individual Route to the RouteResponse, aligning with the Directions API. However, it looks like it kept around a vestigial DirectionsResult.routeIdentifier property. We should remove this property. However, if we need to defer this work past v1.0, then we should instead deprecate the property and wait until v2.0 to remove it.

mapbox-directions-swift/Sources/MapboxDirections/DirectionsResult.swift

Lines 153 to 158 in 8438c7a

	/**
	A unique identifier for a directions request.
	Each route produced by a single call to `Directions.calculate(_:completionHandler:)` has the same route identifier.
	*/
	open var routeIdentifier: String?

mapbox-directions-swift/Sources/MapboxDirections/DirectionsResult.swift

Line 59 in 8438c7a

routeIdentifier = try container.decodeIfPresent(String.self, forKey: .routeIdentifier)

By design, this property is no longer set to anything, but there are still unit tests that assert that it is set to a meaningful value. These tests pass because we haven’t updated the test fixtures.

/cc @mapbox/navigation-ios

[1ec5]

The postprocessing step imbues each route with its surrounding response’s UUID, so the values do match, even if it’s a code smell to use this vestigial property:

mapbox-directions-swift/Sources/MapboxDirections/RouteResponse.swift

Line 131 in 8438c7a

route.routeIdentifier = identifier

[Udumft]

Closed by #562