Additional Incident members #672
Conversation
|
|
||
| let value: Int | ||
| var clampedValue: Int? { | ||
| value == 101 ? nil : value |
There was a problem hiding this comment.
The doc says that value can range from 0 up to 101. Directions team clarified that 101 value indicates something like "invalid state" which effectively means that there is no congestion data available. So, for the sake of simplifying, and since both cases means the same for the end user, I've added this conversion.
There was a problem hiding this comment.
Oh I see, it's what's stated in the public doc you linked too.
There was a problem hiding this comment.
Worth having a named constant for 101 with a link to docs if possible.
| /// List of roads names affected by the incident. | ||
| /// | ||
| /// Alternate road names are separated by a /. The list is ordered from the first affected road to the last one that the incident lies on. | ||
| public var affectedRoadNames: [String]? |
There was a problem hiding this comment.
Android also maps lanesClearDesc property. I managed to find out that this is some kind of a value extracted from telemetry and mapped by NN "as is", but I could not find out what it exactly means, what values it may or may not contain and if it was meant for user display at all. Also, Directions object does not have any analog of that field.
Given that I decided not to expose a property which we cannot support or even explain even if Android does so.
…e and removed the magic constant.
This PR exposes missing Incident members as country codes, closed road flag, long description, etc.