New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mobile offline event #76

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
3 participants
@captainbarbosa
Contributor

captainbarbosa commented Oct 3, 2018

Add mobile offline event
Add (failing) test

Actually set attributes 🤦🏻‍♀️

@captainbarbosa captainbarbosa requested a review from rclee Oct 4, 2018

@rclee

rclee approved these changes Oct 4, 2018

Looks great 👍

@captainbarbosa captainbarbosa merged commit 3fbaff0 into master Oct 4, 2018

1 check passed

ci/bitrise/63d52d847cdb36db/push Passed - mapbox-events-ios
Details

@captainbarbosa captainbarbosa deleted the ios-offline-event branch Oct 4, 2018

@zugaldia

This comment has been minimized.

Show comment
Hide comment
@zugaldia

zugaldia Oct 5, 2018

Member

We should cherrypick this one into the release-gazpacho branch if possible. cc/ @julianrex @chloekraw

Member

zugaldia commented Oct 5, 2018

We should cherrypick this one into the release-gazpacho branch if possible. cc/ @julianrex @chloekraw

@friedbunny friedbunny changed the title from [WIP] Add mobile offline event to Add mobile offline event Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment