New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parent tile retention for overzoomed tiles #5295

Merged
merged 1 commit into from Sep 14, 2017

Conversation

Projects
None yet
2 participants
@mollymerp
Member

mollymerp commented Sep 14, 2017

fix #5290

the scaledTo function wasn't returning the correct values for parents of overzoomed tiles resulting in loaded parents not being retained and a flicker.

cc @ryanbaumann

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page

@mollymerp mollymerp requested a review from anandthakker Sep 14, 2017

@anandthakker

Ah, I see. In native, there's a distinction between a CanonicalTileID and an OverscaledTileID, but here both are represented by TileCoord. I suppose we should eventually bring these two implementations into closer sync

@mollymerp

This comment has been minimized.

Show comment
Hide comment
@mollymerp

mollymerp Sep 14, 2017

Member

yep, exactly @anandthakker – I agree it would be useful to get TileCoord more in sync with native

Member

mollymerp commented Sep 14, 2017

yep, exactly @anandthakker – I agree it would be useful to get TileCoord more in sync with native

@mollymerp mollymerp merged commit 3634d94 into master Sep 14, 2017

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@mollymerp mollymerp deleted the retain-overzoomed-parents branch Sep 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment