New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update SDK compatibility versions for line-gradient #7281

Merged
merged 1 commit into from Sep 20, 2018

Conversation

Projects
None yet
2 participants
@captainbarbosa
Contributor

captainbarbosa commented Sep 14, 2018

Updates the SDK compatibility table for the new line-gradient property introduced in mapbox/mapbox-gl-native#12575.

@captainbarbosa captainbarbosa self-assigned this Sep 14, 2018

@captainbarbosa captainbarbosa requested review from friedbunny and 1ec5 Sep 14, 2018

@captainbarbosa

This comment has been minimized.

Show comment
Hide comment
@captainbarbosa

captainbarbosa Sep 14, 2018

Contributor

@1ec5 I think I may have editing the wrong file (src/style-spec/reference/v8.json vs. your edits on docs/pages/style-spec.js in #7282). Can you confirm that I should be editing style-spec.js instead?

Contributor

captainbarbosa commented Sep 14, 2018

@1ec5 I think I may have editing the wrong file (src/style-spec/reference/v8.json vs. your edits on docs/pages/style-spec.js in #7282). Can you confirm that I should be editing style-spec.js instead?

@1ec5

1ec5 approved these changes Sep 20, 2018 edited

v8.json is where you edit layer properties. #7282 touches a different file where source properties are defined in more of an ad-hoc fashion.

@captainbarbosa captainbarbosa merged commit a5f9d92 into mb-pages Sep 20, 2018

9 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-size Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prepare Your tests passed on CircleCI!
Details
ci/circleci: test-expressions Your tests passed on CircleCI!
Details
ci/circleci: test-flow Your tests passed on CircleCI!
Details
ci/circleci: test-query Your tests passed on CircleCI!
Details
ci/circleci: test-render Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details

@captainbarbosa captainbarbosa deleted the ios-v4.0.0-update branch Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment