Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid throwing styleimagemissing event for empty strings #8840

Merged
merged 1 commit into from Oct 7, 2019

Conversation

ryanhamley
Copy link
Contributor

Launch Checklist

Fixes #8800

  • briefly describe the changes in this PR
    • The image operator treated empty strings the same as any other string so the styleimagemissing operator was fired with icon-image: "". This PR filters out the empty string and treats it as if icon-image was not defined.
  • manually test the debug page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop warning thrown when image equates to "" and image expression type is not used
3 participants