New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Mobile touch events #949

Merged
merged 7 commits into from Jun 12, 2015

Conversation

Projects
None yet
10 participants
@edenh
Contributor

edenh commented Jan 22, 2015

Previously #749.

A work in progress, resolves #657. Rendering is pretty funny though #750.

  • panning
  • pinch zoom
  • pinch rotate
  • panning while pinch-zooming
  • double tap
  • add tests for updated easeTo

@edenh edenh changed the title from Touch to Mobile touch events Jan 22, 2015

@edenh edenh referenced this pull request Jan 22, 2015

Closed

Touch support for iOS8 #749

4 of 6 tasks complete

@jfirebaugh jfirebaugh modified the milestone: v0.6.0 Jan 22, 2015

@alakra

This comment has been minimized.

Show comment
Hide comment
@alakra

alakra Feb 3, 2015

Looking forward to this functionality. Thanks for doing this!

alakra commented Feb 3, 2015

Looking forward to this functionality. Thanks for doing this!

@madjam002

This comment has been minimized.

Show comment
Hide comment
@madjam002

madjam002 Feb 4, 2015

I gave this a try on my single page app, it works really well apart from one problem I seemed to be having.
The map I was using it on covered the whole page, but when I called map.remove(), I couldn't scroll on any other page on my app even though the map was no longer visible and the map DOM element had been removed. Maybe the touch events aren't being unregistered?

madjam002 commented Feb 4, 2015

I gave this a try on my single page app, it works really well apart from one problem I seemed to be having.
The map I was using it on covered the whole page, but when I called map.remove(), I couldn't scroll on any other page on my app even though the map was no longer visible and the map DOM element had been removed. Maybe the touch events aren't being unregistered?

@jfirebaugh jfirebaugh modified the milestone: v0.6.0 Feb 10, 2015

@mourner mourner referenced this pull request Feb 27, 2015

Closed

'hover' event - mousemove? #713

@1ec5

This comment has been minimized.

Show comment
Hide comment
@1ec5

1ec5 May 11, 2015

Member

Might be worth ensuring that how the map responds to touch gestures matches what’s been implemented in Mapbox GL for iOS and Android (mapbox/mapbox-gl-native#1292, mapbox/mapbox-gl-native#553).

Member

1ec5 commented May 11, 2015

Might be worth ensuring that how the map responds to touch gestures matches what’s been implemented in Mapbox GL for iOS and Android (mapbox/mapbox-gl-native#1292, mapbox/mapbox-gl-native#553).

@blq

This comment has been minimized.

Show comment
Hide comment
@blq

blq May 22, 2015

What's the status of touch for the web version?
I don't get any touch response in Chrome on Sony Z3 or HTC One M8 for example :(

blq commented May 22, 2015

What's the status of touch for the web version?
I don't get any touch response in Chrome on Sony Z3 or HTC One M8 for example :(

Show outdated Hide outdated js/ui/handlers.js Outdated

@tmcw tmcw changed the title from Mobile touch events to [wip] Mobile touch events May 26, 2015

@mourner mourner referenced this pull request May 28, 2015

Closed

Too slow on Chrome Mobile #1226

@vespakoen

This comment has been minimized.

Show comment
Hide comment
@vespakoen

vespakoen Jun 2, 2015

Hey guys,

Thanks for this! I am able to use mapbox-gl-js on my android phone now because of your great work!

I merged the latest master branch into the touch branch, and only had to change a couple of things afterwards to make it work again (at least on my Samsung Galaxy Mini S4)

I have published it here: https://github.com/trappsnl/mapbox-gl-js/tree/touch

Not sure if I should make a new pull request now? or I guess @edenh can merge my changes into this one?

Anyways, I'll try to help as much as I can for Android support, and have some more devices where I will test this on.

vespakoen commented Jun 2, 2015

Hey guys,

Thanks for this! I am able to use mapbox-gl-js on my android phone now because of your great work!

I merged the latest master branch into the touch branch, and only had to change a couple of things afterwards to make it work again (at least on my Samsung Galaxy Mini S4)

I have published it here: https://github.com/trappsnl/mapbox-gl-js/tree/touch

Not sure if I should make a new pull request now? or I guess @edenh can merge my changes into this one?

Anyways, I'll try to help as much as I can for Android support, and have some more devices where I will test this on.

@stepankuzmin

This comment has been minimized.

Show comment
Hide comment
@stepankuzmin

stepankuzmin Jun 5, 2015

Contributor

+1 for this. I'm using https://mapbox.s3.amazonaws.com/mapbox-gl-js/master/mapbox-gl-dev.js but touch events still not working (iPhone 5s with iOS 8, Safari, Chrome).

Contributor

stepankuzmin commented Jun 5, 2015

+1 for this. I'm using https://mapbox.s3.amazonaws.com/mapbox-gl-js/master/mapbox-gl-dev.js but touch events still not working (iPhone 5s with iOS 8, Safari, Chrome).

@mourner

This comment has been minimized.

Show comment
Hide comment
@mourner

mourner Jun 5, 2015

Member

I'll look into finishing and merging this early next week.
@vespakoen thanks for the help!

Member

mourner commented Jun 5, 2015

I'll look into finishing and merging this early next week.
@vespakoen thanks for the help!

@mourner mourner self-assigned this Jun 11, 2015

@jfirebaugh jfirebaugh added this to the 0.8 milestone Jun 11, 2015

@mourner

This comment has been minimized.

Show comment
Hide comment
@mourner

mourner Jun 12, 2015

Member

Currently broken because of #1268

Member

mourner commented Jun 12, 2015

Currently broken because of #1268

@mourner mourner merged commit 1d03d91 into master Jun 12, 2015

1 check was pending

ci/circleci CircleCI is running your tests
Details

@mourner mourner deleted the touch branch Jun 12, 2015

@mourner

This comment has been minimized.

Show comment
Hide comment
@mourner

mourner Jun 12, 2015

Member

Will handle subsequent improvements in further commits.

Member

mourner commented Jun 12, 2015

Will handle subsequent improvements in further commits.

@vespakoen

This comment has been minimized.

Show comment
Hide comment
@vespakoen

vespakoen Jun 12, 2015

👍 Awesome!! Thanks a lot!

vespakoen commented Jun 12, 2015

👍 Awesome!! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment