Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

onDidBecomeIdle is not called when adding a VectorSource with an invalid URL #15757

Closed
julianrex opened this issue Oct 3, 2019 · 1 comment
Closed
Labels
archived Archived because of inactivity bug Core The cross-platform C++ core, aka mbgl

Comments

@julianrex
Copy link
Contributor

julianrex commented Oct 3, 2019

Reproduced on iOS, though I believe this is a lower-level issue.

Steps to reproduce

  1. Add an MGLVectorTileSource to the style, with an invalid configuration URL (or valid config but without access)
  2. Move the map
  3. mapViewDidBecomeIdle is not called.

Note: discovered during testing of #15744

Expected behavior

onDidBecomeIdle should be called if sources with invalid URLs are non-recoverable.

Actual behavior

In Map::Impl::onDidFinishRenderingFrame the renderMode is always Partial, meaning that onDidBecomeIdle is not called.

Configuration

Tested as of: 6965fc3

@julianrex julianrex added bug Core The cross-platform C++ core, aka mbgl labels Oct 3, 2019
@stale stale bot added the archived Archived because of inactivity label Mar 31, 2020
@stale
Copy link

stale bot commented Mar 31, 2020

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived Archived because of inactivity bug Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

No branches or pull requests

1 participant