New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "video" source type #601

Open
incanus opened this Issue Nov 13, 2014 · 13 comments

Comments

Projects
None yet
8 participants
@incanus
Contributor

incanus commented Nov 13, 2014

https://github.com/mapbox/mapbox-gl-js/blob/mb-pages/js/source/video_source.js

I'm imagining this is going to work totally differently than JS. That AFAICT uses an out-of-view video <div> that plays back and whose content snapshot is grabbed periodically to use in GL frames.

On native we'd likely have to decode video directly and get frames that way.

@ljbade

This comment has been minimized.

Show comment
Hide comment
@ljbade

ljbade Nov 14, 2014

Contributor

ah, this is going to be hard and need a lot of dependencies, guess we start with whatever lib VLC is using if we want a lot of format support

or do we just allow h.264 only so we only depend on one library

or on android we could perhaps leverage the platform support for video, need to look at how we can do this from native without being too slow

Contributor

ljbade commented Nov 14, 2014

ah, this is going to be hard and need a lot of dependencies, guess we start with whatever lib VLC is using if we want a lot of format support

or do we just allow h.264 only so we only depend on one library

or on android we could perhaps leverage the platform support for video, need to look at how we can do this from native without being too slow

@artemp

This comment has been minimized.

Show comment
Hide comment
@ljbade

This comment has been minimized.

Show comment
Hide comment
@ljbade

ljbade Nov 14, 2014

Contributor

@artemp wasn't there a project split a while back from ffmpeg? what is the other one?

Contributor

ljbade commented Nov 14, 2014

@artemp wasn't there a project split a while back from ffmpeg? what is the other one?

@artemp

This comment has been minimized.

Show comment
Hide comment
@artemp

artemp Nov 14, 2014

Member

@ljbade - yes, there is http://libav.org/. Both libs seems to be active - I guess we need pick one.

Member

artemp commented Nov 14, 2014

@ljbade - yes, there is http://libav.org/. Both libs seems to be active - I guess we need pick one.

@jfirebaugh

This comment has been minimized.

Show comment
Hide comment
@jfirebaugh

jfirebaugh Nov 14, 2014

Member

My first instinct is to use platform APIs here.

Member

jfirebaugh commented Nov 14, 2014

My first instinct is to use platform APIs here.

@ljbade

This comment has been minimized.

Show comment
Hide comment
@ljbade

This comment has been minimized.

Show comment
Hide comment
@ljbade

ljbade Nov 16, 2014

Contributor

Also can we make a call on whether we should only support H.264? It will make things a lot easier.

Contributor

ljbade commented Nov 16, 2014

Also can we make a call on whether we should only support H.264? It will make things a lot easier.

@jfirebaugh

This comment has been minimized.

Show comment
Hide comment
@jfirebaugh

jfirebaugh Nov 17, 2014

Member

I think it would be fine for certain platforms to support H.264 only. The way a GL style video source works is modeled on the HTML5 <video> element -- the style author can provide several source URLs in different formats and the renderer will pick the one with best support.

Member

jfirebaugh commented Nov 17, 2014

I think it would be fine for certain platforms to support H.264 only. The way a GL style video source works is modeled on the HTML5 <video> element -- the style author can provide several source URLs in different formats and the renderer will pick the one with best support.

@incanus

This comment has been minimized.

Show comment
Hide comment
@incanus

incanus Nov 17, 2014

Contributor

My first instinct is to use platform APIs here.

I'm leaning this way as well.

@incanus what platform support does iOS have?

APIs are great, from what I hear, but I don't have a lot of direct experience. I've done a bit on iPad with assembling frames of video and syncing to audio, but not much. But in general, media support is pretty nice on iOS with good high-level APIs.

Contributor

incanus commented Nov 17, 2014

My first instinct is to use platform APIs here.

I'm leaning this way as well.

@incanus what platform support does iOS have?

APIs are great, from what I hear, but I don't have a lot of direct experience. I've done a bit on iPad with assembling frames of video and syncing to audio, but not much. But in general, media support is pretty nice on iOS with good high-level APIs.

@kkaefer

This comment has been minimized.

Show comment
Hide comment
@kkaefer

kkaefer Nov 24, 2014

Contributor

We definitely should use platform APIs here. I think it's fair to not support video on Android 2/3, and to require H.264.

Contributor

kkaefer commented Nov 24, 2014

We definitely should use platform APIs here. I think it's fair to not support video on Android 2/3, and to require H.264.

@incanus incanus referenced this issue Aug 20, 2015

Closed

Offline maps #584

@jfirebaugh jfirebaugh changed the title from port video support to Support "video" source type Sep 27, 2016

@jfirebaugh jfirebaugh added the Core label Sep 27, 2016

@dylan-chong

This comment has been minimized.

Show comment
Hide comment
@dylan-chong

dylan-chong Jul 23, 2018

Is this issue dead? :|

Is this issue dead? :|

@ChrisLoer

This comment has been minimized.

Show comment
Hide comment
@ChrisLoer

ChrisLoer Jul 23, 2018

Contributor

@asheemmamoowala Do I remember you had an example of how to include video support via custom layers?

Contributor

ChrisLoer commented Jul 23, 2018

@asheemmamoowala Do I remember you had an example of how to include video support via custom layers?

@asheemmamoowala

This comment has been minimized.

Show comment
Hide comment
@asheemmamoowala

asheemmamoowala Aug 16, 2018

Contributor

There's a demo of how to do this using custom layers at: https://github.com/asheemmamoowala/MapboxMapVideoLayer

The video is jittery at high zooms when being interacted with, and it consumes a lot of energy.
ezgif com-resize

Contributor

asheemmamoowala commented Aug 16, 2018

There's a demo of how to do this using custom layers at: https://github.com/asheemmamoowala/MapboxMapVideoLayer

The video is jittery at high zooms when being interacted with, and it consumes a lot of energy.
ezgif com-resize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment