Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Added zh-rCN strings.xml file for Simplified Chinese characters #12696

Merged

Conversation

langsmith
Copy link
Contributor

This pr adds a strings.xml file for Simplified Chinese characters so that the telemetry window's text will be translated if the device is set to Simplified Chinese.

@macro-shen @chriswu42 @suntony @springmeyer @jmkiley @lloydsheng

device-2018-08-21-111622

@tobrun @LukasPaczos , is there a reason why Telemetry Settings is hardcoded rather than being open to translation? No matter what language I put my device into, IMPROVE THIS MAP and TELEMETRY SETTINGS appear in English.

device-2018-08-21-112313

@langsmith langsmith added Android Mapbox Maps SDK for Android localization Human language support and internationalization labels Aug 21, 2018
@langsmith langsmith self-assigned this Aug 21, 2018
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , will go ahead a merge this so it can be included in alpha release of today

@tobrun tobrun merged commit 250eaff into master Aug 22, 2018
@tobrun
Copy link
Member

tobrun commented Aug 22, 2018

@tobrun @LukasPaczos , is there a reason why Telemetry Settings is hardcoded rather than being open to translation? No matter what language I put my device into, IMPROVE THIS MAP and TELEMETRY SETTINGS appear in English.

Will address this before the alpha release as well.

@tobrun tobrun deleted the ls-pulling-in-simplified-chinese-character-translations branch August 22, 2018 04:31
@tobrun
Copy link
Member

tobrun commented Aug 22, 2018

@langsmith -> #12708 and #12707

@langsmith
Copy link
Contributor Author

Thanks for all of the follow up work around this @tobrun

@langsmith langsmith restored the ls-pulling-in-simplified-chinese-character-translations branch August 23, 2018 03:40
@langsmith langsmith deleted the ls-pulling-in-simplified-chinese-character-translations branch August 24, 2018 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android localization Human language support and internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants