This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Fix cubic-bezier interpolation for zooms outside stop range. #12826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue #12812. Using `util::interpolationFactor` handles the case where inputLevels.min == inputLevels.max, so it returns an interpolation factor of "0" instead of dividing by 0.
jfirebaugh
approved these changes
Sep 5, 2018
|
@ChrisLoer I checked this out with the style in question (that uses cubic-bezier zoom-dependent interpolation for text-size), and it looks good to me (see screenshots below). 👍 As you requested in chat, I reviewed the visual behavior of the style after the last designated stop in the curve, and it looks as expected – the text-size stays static beyond the last zoom stop, which is the same behavior as with gl-js. Thanks so much for getting this bug fix in so quickly 🙇 Also thanks to @riastrad for helping me with the local build to review this 🙇
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #12812.
Using
util::interpolationFactorhandles the case where inputLevels.min == inputLevels.max, so it returns an interpolation factor of "0" instead of dividing by 0.@nickidlugash, can you build this branch, try it out with your style, and make sure you get the results you expect?
@jfirebaugh, does this look right to you? I'll start work on a regression test for this on the gl js side...