This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Force attribution, title-casing tests to pass #13387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a title-casing test when run in a non-English locale. The test was written only for English anyways.
julianrex
approved these changes
Nov 16, 2018
|
This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #11391 that ensures the attribution and title-casing tests pass on iOS and macOS regardless of system version or locale. The changes include a workaround for an AppKit bug and a hard-coded locale identifier (for folks like me who run macOS or iOS in a language other than English).
Fixes #13386.
/cc @julianrex @friedbunny