This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[CP][core][android] Decouple vacuum from other operations on offline database #16029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduce `OfflineDatabase::pack()` standing for incremental vacuum - make pack optional at offline region deletion - update `OfflineDatabase.DeleteRegion` test accordingly to the items above
Add `packDatabase()` method and `bool pack` argument to the `deleteOfflineRegion()` method.
- added a unit test - Updated inline comments in default_file_source.hpp
pozdnyakov
added
Android
tobrun
approved these changes
Dec 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request CPs pieces of #15899 and #15967 and introduces
OfflineManager.runPackDatabaseAutomatically(boolean)andOfflineManager. packDatabase(boolean)API in order to enable decoupling vacuum operation from other operations run on the offline database file (delete offline region, clear ambient cache)