Add MaxSpeed Annotation to Directions API #772
Conversation
| * | ||
| * @since 2.1.0 | ||
| */ | ||
| public static final String ANNOTATION_MAX_SPEED = "maxspeed"; |
There was a problem hiding this comment.
A nitpicky observation... could this be ANNOTATION_MAXSPEED to match the spelling of maxspeed used everywhere else and to avoid confusion with a "max integer" type constant?
|
@karenzshea good call, just updated. Also finished the |
danesfeder
changed the title
| /** | ||
| * String indicating the unit of speed, either as `kmh` or `mph`. | ||
| * | ||
| * @param unit either as `kmh` or `mph` |
There was a problem hiding this comment.
According to our fastidious colleagues, this technically should say km/h (because kmh apparently indicates a non-existent measure of kilometers of force blablabla 🙄 ). The api will return either km/h or mph
There was a problem hiding this comment.
@karenzshea Yeah thanks for the clarification here. I was 🤔 this when looking at the api docs PR
danesfeder
force-pushed
the
dan-add-maxspeed
branch
2 times, most recently
from
0af1024
to
f213c4e
Compare
|
Wait - one last question! Does this need tests? |
|
@karenzshea definitely. added our model tests |
|
@osana can we sneak this in for |
|
Added to 3.0 milestone |
danesfeder
force-pushed
the
dan-add-maxspeed
branch
from
7ab51b7
to
a2b2ddc
Compare
|
closed #740 |
cc @karenzshea