Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate gesture settings increaseRotateThresholdWhenPinchingToZoom #1632

Conversation

jush
Copy link
Member

@jush jush commented Aug 30, 2022

Summary of changes

Deprecate gesture settings increaseRotateThresholdWhenPinchingToZoom property.

User impact (optional)

None. The property was not used and had no effect.

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Run make update-api to update generated api files, if there's public API changes, otherwise the verify-api-* CI steps might fail.
  • Update CHANGELOG.md or use the label 'skip changelog', otherwise check changelog CI step will fail.
  • If this PR is a v10.[version] release branch fix / enhancement, merge it to main firstly and then port to v10.[version] release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@jush jush requested a review from a team as a code owner August 30, 2022 10:08
@jush jush force-pushed the rs-deprecate-gesturesettings-increaseRotateThresholdWhenPinchingToZoom-MAPSAND-222 branch from 47067de to 77719bc Compare August 30, 2022 11:22
CHANGELOG.md Outdated Show resolved Hide resolved
@jush jush force-pushed the rs-deprecate-gesturesettings-increaseRotateThresholdWhenPinchingToZoom-MAPSAND-222 branch from 77719bc to cd10569 Compare August 30, 2022 13:42
Copy link
Member

@pengdev pengdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jush jush merged commit 308541d into main Aug 31, 2022
@jush jush deleted the rs-deprecate-gesturesettings-increaseRotateThresholdWhenPinchingToZoom-MAPSAND-222 branch August 31, 2022 12:28
mapbox-github-ci-writer-public-1 bot pushed a commit that referenced this pull request Apr 20, 2023
* Fix raw expression parsing for list literal. (#1629)

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants