From cd1056988ecaa82053f211ac49a1d31012be165e Mon Sep 17 00:00:00 2001 From: Ramon Sadornil Date: Tue, 30 Aug 2022 13:05:01 +0300 Subject: [PATCH] Deprecate gesture settings increaseRotateThresholdWhenPinchingToZoom property --- CHANGELOG.md | 1 + plugin-gestures/src/main/res-public/values/public.xml | 3 ++- sdk-base/api/metalava.txt | 6 +++--- .../plugin/gestures/generated/GesturesSettingsInterface.kt | 1 + 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5e366a570b..c1c648df39 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ Mapbox welcomes participation and contributions from everyone. # main ## Features ✨ and improvements 🏁 +* Deprecated gesture settings `increaseRotateThresholdWhenPinchingToZoom` property. ([1632](https://github.com/mapbox/mapbox-maps-android/pull/1632)) ## Bug fixes 🐞 * Fix scale bar truncated at high zoom levels near the poles. ([1620](https://github.com/mapbox/mapbox-maps-android/pull/1620)) diff --git a/plugin-gestures/src/main/res-public/values/public.xml b/plugin-gestures/src/main/res-public/values/public.xml index 38f2b55d75..8fad40dc9c 100644 --- a/plugin-gestures/src/main/res-public/values/public.xml +++ b/plugin-gestures/src/main/res-public/values/public.xml @@ -43,7 +43,8 @@ - + diff --git a/sdk-base/api/metalava.txt b/sdk-base/api/metalava.txt index c852976eca..1293a7fcba 100644 --- a/sdk-base/api/metalava.txt +++ b/sdk-base/api/metalava.txt @@ -1839,7 +1839,7 @@ package com.mapbox.maps.plugin.gestures.generated { method public boolean getDoubleTouchToZoomOutEnabled(); method public com.mapbox.maps.ScreenCoordinate? getFocalPoint(); method public boolean getIncreasePinchToZoomThresholdWhenRotating(); - method public boolean getIncreaseRotateThresholdWhenPinchingToZoom(); + method @Deprecated public boolean getIncreaseRotateThresholdWhenPinchingToZoom(); method public boolean getPinchScrollEnabled(); method public boolean getPinchToZoomDecelerationEnabled(); method public boolean getPinchToZoomEnabled(); @@ -1857,7 +1857,7 @@ package com.mapbox.maps.plugin.gestures.generated { method public void setDoubleTouchToZoomOutEnabled(boolean doubleTouchToZoomOutEnabled); method public void setFocalPoint(com.mapbox.maps.ScreenCoordinate? focalPoint); method public void setIncreasePinchToZoomThresholdWhenRotating(boolean increasePinchToZoomThresholdWhenRotating); - method public void setIncreaseRotateThresholdWhenPinchingToZoom(boolean increaseRotateThresholdWhenPinchingToZoom); + method @Deprecated public void setIncreaseRotateThresholdWhenPinchingToZoom(boolean increaseRotateThresholdWhenPinchingToZoom); method public void setPinchScrollEnabled(boolean pinchScrollEnabled); method public void setPinchToZoomDecelerationEnabled(boolean pinchToZoomDecelerationEnabled); method public void setPinchToZoomEnabled(boolean pinchToZoomEnabled); @@ -1875,7 +1875,7 @@ package com.mapbox.maps.plugin.gestures.generated { property public abstract boolean doubleTouchToZoomOutEnabled; property public abstract com.mapbox.maps.ScreenCoordinate? focalPoint; property public abstract boolean increasePinchToZoomThresholdWhenRotating; - property public abstract boolean increaseRotateThresholdWhenPinchingToZoom; + property @Deprecated public abstract boolean increaseRotateThresholdWhenPinchingToZoom; property public abstract boolean pinchScrollEnabled; property public abstract boolean pinchToZoomDecelerationEnabled; property public abstract boolean pinchToZoomEnabled; diff --git a/sdk-base/src/main/java/com/mapbox/maps/plugin/gestures/generated/GesturesSettingsInterface.kt b/sdk-base/src/main/java/com/mapbox/maps/plugin/gestures/generated/GesturesSettingsInterface.kt index 69d7b8e53a..dae01ac70b 100644 --- a/sdk-base/src/main/java/com/mapbox/maps/plugin/gestures/generated/GesturesSettingsInterface.kt +++ b/sdk-base/src/main/java/com/mapbox/maps/plugin/gestures/generated/GesturesSettingsInterface.kt @@ -91,6 +91,7 @@ interface GesturesSettingsInterface { /** * Whether rotate threshold increases when pinching to zoom. true by default. */ + @Deprecated(message = "This property has no effect") var increaseRotateThresholdWhenPinchingToZoom: Boolean /**