Remove unused images when updating point annotations #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OdNairy
approved these changes
Sep 19, 2022
Sources/MapboxMaps/Annotations/PointAnnotation+ImageHandling.swift
Outdated
Show resolved
Hide resolved
persidskiy
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Fix for Style/updateLayer fail if nested properties dictionary contains nil (#1565) - Error happens due to layer's properties contains nil values for nested keys, for these keys, default values will not be applied so they would appear as nil when updating a layer. The fix is to only apply nil encoding for the root properties of the dictionary. * Flag MapRecorder with @_spi(Internal) (#1582) * Remove unused images when updating point annotations (#1583) * Parse GeoJSON data on a background queue (#1576) * Fix toString conversion on iOS 12 (#1584) * Use asynchronous GeoJSON marshaling in annotation managers (#1588) * update generated docs (#1586) * Fix GeoJSONData.url incorrectly converting to string (#1587) * Expose distance-from-center and pitch expressions (#1559) * Bump MapboxCoreMaps and MapboxCommon (#1589) * Expose opacity for location puck (#1585) * Fix merge issues Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Ankur Khandelwal <ankur.khandelwal@mapbox.com> Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com> Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PointAnnotationManagercan add images from point annotations to style, but doesn't remove them when annotations are updated or when the manager is destroyed. This PR makes point annotation manager to remove unused images when updating annotations, as well as to remove all annotation images when the manager gets destroyed.Pull request checklist:
## mainheading near the top).PRs must be submitted under the terms of our Contributor License Agreement CLA.