Upload code coverage to internal service #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OdNairy
force-pushed
the
feature/internal-coverage
branch
2 times, most recently
from
5b4014a
to
55d555f
Compare
Codecov Report
@@ Coverage Diff @@
## main #1734 +/- ##
=======================================
Coverage 83.17% 83.18%
=======================================
Files 241 241
Lines 14848 14848
=======================================
+ Hits 12350 12351 +1
+ Misses 2498 2497 -1
|
OdNairy
force-pushed
the
feature/internal-coverage
branch
from
55d555f
to
c671890
Compare
evil159
approved these changes
Nov 17, 2022
evil159
pushed a commit
that referenced
this pull request
Nov 18, 2022
* Drop commented coverage rule from Makefile * Upload coverage to internal service * Return slack message report on unit test failure in main branch * Rename xcodebuild log * Improve CI job naming * Enable codecov/patch check * Install s3 credentials * Force enable codecov/patch and remove unused flags
evil159
added a commit
that referenced
this pull request
Nov 18, 2022
* Remove 10s delay as CoreTelemetry does not freeze main thread (#1699) * Update generated code to use latest spec (#1696) * Add missing changelog entry (#1707) * Update generated code (#1708) * Flush telemetry on MapView deinit (#1700) * Refactoring to use EventsManager init over shared * Add explicit flush on EventsManager deinit (happens on MapView deinit as well) * Send map.load event with queued priority * Some unit tests refactoring * Add iPhone XR iOS 12 to the test device list (#1715) * Expand cluster example to show additional functionality (#1713) * Expand example to include zooming on cluster click * Add documentation details * Fix language support and label localization (#1687) * Change tests to correct expectations, modify implementation * Pull in Nav changes * Port localization approach from nav * Address PR feedback * Expand test coverage * Respond to review, enable passing system Locale * Add additional tests * Clean up implementation, add additional tests * Add changelog entry * Update changelog * Use Test Plans for Examples target to avoid unit tests on CI (#1716) Adding two test plans: - The default includes Examples tests along with UI tests and Maps unit tests - The second test plan ignores unit tests to support running tests on devices (SPM unit tests doesn't have a host app so cannot be run on iOS devices) Fixes for Changelog broken URLs * Support iOS 12 for location permission dialog workaround (#1719) * Support iOS 12 for location permission dialog workaround * Rewrite Accept location UI test in favor of buttons awaitance * Resolve Hans handling on v7 (#1720) * Begin migration to test plans, split unit and integration tests (#1714) * Begin migration to test plans, split unit and integration tests * Add workspace * Move over additional schemes * Update Debugapp TestPlan * Update directories * Undo example changes * A few test plan fixes Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update test checklist item (#1724) * sync swift version (#1726) * Update Swift version in podspec * Update swift version in SPM * Run unit tests on multiple supported iOS versions (#1718) * Bump ci latest Xcode executor to `14.1.0` (#1729) * Update CI xcode image to 14.1 * Fix testplans issue * Update iPhone destination * Force test plan * Bump MapboxCoreMaps to 10.10.0-rc.1 and MapboxCommon to 23.2.0-rc.2 (#1727) * Minor setup fixes (#1730) * Update Xcode build settins recommendation base * Fix a few warnings in unit tests * Reduce number of base-job uses * Use large machine for build-sdk job * Do not build tests on MapboxMaps * Revert "Use large machine for build-sdk job" This reverts commit 0e29027. * DIsable testability * Stop building DebugApp in build-sdk job * Add explicit dependency installation steps * Skip dependencies for some jobs * Extract install dependencies commands * Rename some dependency commands * Update google cloud SDK * More skip dependencies * Support custom repository URL based on CircleCI values * Install python deps for release build jobs * Use ssh for integration validation (#1731) * Reenable Codecov (#1666) * Add Codecov uploader * Store coverage report * Upload code coverage to internal service (#1734) * Drop commented coverage rule from Makefile * Upload coverage to internal service * Return slack message report on unit test failure in main branch * Rename xcodebuild log * Improve CI job naming * Enable codecov/patch check * Install s3 credentials * Force enable codecov/patch and remove unused flags * Collect unit and integration tests coverage separately (#1736) * Test unit tests and integrations tests separately * Disable parallel testing to fix empty JUnit report * Enable English language by default * Parallelize tests in All test plan * Parallelize tests in IntegrationTests plan * Allow simultaneous recognition of map- and annotation- handling gesture recognizers (#1737) * Bump MapboxCommon to 23.2.0-rc.3 (#1738) * Bump SDK version to 10.10.0-rc.1 (#1739) Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
custom_categories(scripts/doc-generation/.jazzy.yaml)## mainheading near the top).v10.[version]release branch fix / enhancement, merge it tomainfirst and then port tov10.[version]release branch.PRs must be submitted under the terms of our Contributor License Agreement CLA.
MAPSIOS-451