New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use legacy shields for state routes in the United States #5383
Comments
In this case how do we address the request from customers that the shields in maneuvers should match the shields on the Map, since as far as I know Map continues to use generic mapbox designed shields.
cc @1ec5 |
The requirement was for consistency in general, but this is a special case where consistency with the map would come at the expense of usability and amount to a regression compared to earlier versions.
This is only applicable to the |
This was implemented on iOS in mapbox/mapbox-navigation-ios#3723. |
My mistake, the correct name to look for is |
As of #5145 #5310, the maneuver banner and road name label are using a new set of Mapbox-designed shields. This new set of shield assets regresses the behavior for state routes in the United States. Each state has a very distinct design for its state route shields, but the state-specific shields were omitted due to size and resource limitations. Users still need to see accurate shields to avoid making the wrong decision at highly trafficked interchanges throughout the country.
Until Mapbox-designed state route shields are available, we should use the legacy shields from Wikimedia Commons for state routes. Whenever
mapbox_shield.name
isus-state
circle-white
, useimageBaseURL
instead ofmapbox_shield.base_url
, and append the .png or .svg file extension as desired. (If I’m not mistaken, navigation-native exposesimageBaseURL
as well.) Regardless of file format, the legacy endpoint always bakes the number right into the image, so no compositing is required, but the image can’t be reused for other routes within the same network. The SVG files are not as optimized as the new SVG files and may not conform to the subset of SVG that can be converted to vector drawables. I think it would be acceptable to use the PNG files for this fallback to avoid any uncertainty about SVG conversion./cc @abhishek1508 @jill-cardamon @ShanMa1991 @ClareTrainor
The text was updated successfully, but these errors were encountered: