-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puck Gymnastics #1354
Puck Gymnastics #1354
Conversation
…cation services lag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -23,6 +23,8 @@ synchronized void updateRoute(String routeJson) { | |||
} | |||
|
|||
synchronized NavigationStatus retrieveStatus(Date date) { | |||
// We ask for a point slightly in the future to account for lag in location services | |||
date.setTime(date.getTime() + 1500); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about passing the lag as a parameter of retrieveStatus
so it can be custom? And then we can add a new option in MapboxNavigationOptions
with its corresponding default values (constant in NavigationConstants
).
Other than a couple of formatting nit picks was 💯 You got it! Thanks @kevinkreiser looking forward to test it out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going ahead and merging here.
Thanks again @kevinkreiser
Use nav native 3.1.1 to do small forward prediction to counter-act location services lag. Let me know if we should make a constant for this and indeed where such constants would live!