Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed up NavigationRoute #413

Merged
merged 4 commits into from Oct 24, 2017
Merged

Changed up NavigationRoute #413

merged 4 commits into from Oct 24, 2017

Conversation

cammace
Copy link
Contributor

@cammace cammace commented Oct 23, 2017

This PR adds the following:

The last point was resolved by adding overloading methods which takes in both the coordinate point along with the angle. This ensures that the angle is associated with the correct Point.

@cammace cammace added this to the v0.7.0 milestone Oct 23, 2017
@cammace cammace self-assigned this Oct 23, 2017
Copy link
Contributor

@danesfeder danesfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - looks like checkstyle is failing, but otherwise good to go

@cammace cammace merged commit d5c1e16 into master Oct 24, 2017
@cammace cammace deleted the cam-fix-navigation-route branch October 24, 2017 19:21
Grsmto pushed a commit to Grsmto/mapbox-navigation-android that referenced this pull request Oct 27, 2017
…android into fix-build

* 'master' of https://github.com/mapbox/mapbox-navigation-android:
  Adjust API Milestone to handle new routes (mapbox#425)
  Cancel notification when the service is destroyed, not just when notification button is clicked (mapbox#409)
  adds validation utils class (mapbox#424)
  Wait for map style to load before initializing run time styling (mapbox#423)
  Changed up NavigationRoute (mapbox#413)

# Conflicts:
#	libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationRoute.java
@danesfeder danesfeder mentioned this pull request Nov 13, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants