Fix FeedbackBottomSheet rotation bug #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
requested changes
Feb 14, 2018
|
|
||
| @Override | ||
| public void onDestroyView() { | ||
| // Prevent listener leak |
There was a problem hiding this comment.
What about extracting this block of code into a private method and give it a name based on the comment? This way onDestroyView() will be easier to read and understand and comment will become superfluous so it won't be necessary.
There was a problem hiding this comment.
We should keep public methods as clean as possible so they read like pseudocode (i.e. no conditionals, fors, etc.).
| // Prevent listener leak | ||
| feedbackBottomSheetListener = null; | ||
|
|
||
| // Maintains visibility on rotation |
| if (dialog != null && getRetainInstance()) { | ||
| dialog.setDismissMessage(null); | ||
| } | ||
| // Cancel the animation |
| @Override | ||
| protected void onAttachedToWindow() { | ||
| super.onAttachedToWindow(); | ||
| // Attach the listener to the FeedbackBottomSheet if it is showing |
There was a problem hiding this comment.
What about extracting this block of code into a private method giving it a name based on the comment and then remove it (comment won't be necessary anymore)?
|
@Guardiola31337 thanks, should be good to go 🍍 |
danesfeder
force-pushed
the
dan-bottomsheet-rotation
branch
from
2097d38
to
66e158d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #693