Hide the remaining steps when user is on final step #3729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanMa1991
added
the
UI
|
No breaking changes detected in MapboxCoreNavigation |
|
No breaking changes detected in MapboxNavigation |
ShanMa1991
force-pushed
the
shan/final-step-2015
branch
from
44189de
to
60fa266
Compare
|
No breaking changes detected in MapboxCoreNavigation |
|
No breaking changes detected in MapboxNavigation |
ShanMa1991
force-pushed
the
shan/final-step-2015
branch
from
60fa266
to
14d96e9
Compare
|
No breaking changes detected in MapboxCoreNavigation |
Breaking Changes in MapboxNavigationBreaking API Changes
|
| Type of change: | key.doc.result_discussion |
|---|---|
| From: | [["Para": optionally, a customized NSAttributedString that will be presented instead of the default, or if nil, the default behavior will be used.]] |
| To: | [["Para": Optionally, a customized NSAttributedString that will be presented instead of the default, or if nil, the default behavior will be used.]] |
primaryLabel(_:willPresent:as:) in InstructionsCardContainerViewDelegate
| Type of change: | key.doc.result_discussion |
|---|---|
| From: | [["Para": optionally, a customized NSAttributedString that will be presented instead of the default, or if nil, the default behavior will be used.]] |
| To: | [["Para": Optionally, a customized NSAttributedString that will be presented instead of the default, or if nil, the default behavior will be used.]] |
LanesView
- removed method:
update(for:)inLanesView
bamx23
approved these changes
Feb 11, 2022
ShanMa1991
force-pushed
the
shan/final-step-2015
branch
from
14d96e9
to
df9b28b
Compare
|
No breaking changes detected in MapboxCoreNavigation |
|
No breaking changes detected in MapboxNavigation |
|
No breaking changes detected in MapboxCoreNavigation |
|
No breaking changes detected in MapboxNavigation |
ShanMa1991
force-pushed
the
shan/final-step-2015
branch
from
5e459f0
to
76a3fd7
Compare
|
No breaking changes detected in MapboxCoreNavigation |
|
No breaking changes detected in MapboxNavigation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pr is to fix #2015 to hide the remaining steps when user is on final step.
Implementation
When user arrives on final step,
TopBannerViewControllerwould dismiss thestepsViewControllerand change theinstructionsBannerView.showStepIndicatortofalse. And the step indicator of the instruction banner would be hidden, the swiping and tapping gestures wouldn't work.And if the mobile is in the previewing mode, the previewing process would stop. If the mobile is displaying the remaining steps in pull-down menu, the pull-down table would be dismissed.
Screenshots or Gifs
When in final step, the indicator view would be hidden, swiping and taping gestures wouldn't trigger the remaining steps displaying.
