Fix issues related to routeLineTracksTraversal usage and custom delegate methods for route line modification.
#3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximAlien
added
bug
MaximAlien
force-pushed
the
maxim/2967-fix-route-line-tracks-traversal-when-custom-line-layer-is-used
branch
3 times, most recently
from
9e691b8
to
b667789
Compare
…LineTracksTraversal` is enabled on iOS and CarPlay. Add delegate methods, which provide the ability to modify route line layer and its casing on CarPlay.
MaximAlien
force-pushed
the
maxim/2967-fix-route-line-tracks-traversal-when-custom-line-layer-is-used
branch
from
b667789
to
c1ca445
Compare
…PlayNavigationViewController.delegate`.
|
No breaking changes detected in MapboxCoreNavigation |
Breaking Changes in MapboxNavigationBreaking API Changes
|
| Type of change: | Declaration |
|---|---|
| From: | <Self where Self : NavigationMapViewDelegate> (Self) -> (NavigationMapView, String, String) -> LineLayer? |
| To: | (CarPlayMapViewController) -> (NavigationMapView, String, String) -> LineLayer? |
navigationMapView(_:routeCasingLineLayerWithIdentifier:sourceIdentifier:) in CarPlayMapViewController
| Type of change: | Declaration |
|---|---|
| From: | <Self where Self : NavigationMapViewDelegate> (Self) -> (NavigationMapView, String, String) -> LineLayer? |
| To: | (CarPlayMapViewController) -> (NavigationMapView, String, String) -> LineLayer? |
|
No breaking changes detected in MapboxCoreNavigation |
Breaking Changes in MapboxNavigationBreaking API Changes
|
| Type of change: | Declaration |
|---|---|
| From: | <Self where Self : NavigationMapViewDelegate> (Self) -> (NavigationMapView, String, String) -> LineLayer? |
| To: | (CarPlayMapViewController) -> (NavigationMapView, String, String) -> LineLayer? |
navigationMapView(_:routeLineLayerWithIdentifier:sourceIdentifier:) in CarPlayMapViewController
| Type of change: | Declaration |
|---|---|
| From: | <Self where Self : NavigationMapViewDelegate> (Self) -> (NavigationMapView, String, String) -> LineLayer? |
| To: | (CarPlayMapViewController) -> (NavigationMapView, String, String) -> LineLayer? |
1ec5
approved these changes
Mar 28, 2022
|
No breaking changes detected in MapboxCoreNavigation |
Breaking Changes in MapboxNavigationBreaking API Changes
|
| Type of change: | Declaration |
|---|---|
| From: | <Self where Self : NavigationMapViewDelegate> (Self) -> (NavigationMapView, String, String) -> LineLayer? |
| To: | (CarPlayMapViewController) -> (NavigationMapView, String, String) -> LineLayer? |
navigationMapView(_:routeLineLayerWithIdentifier:sourceIdentifier:) in CarPlayMapViewController
| Type of change: | Declaration |
|---|---|
| From: | <Self where Self : NavigationMapViewDelegate> (Self) -> (NavigationMapView, String, String) -> LineLayer? |
| To: | (CarPlayMapViewController) -> (NavigationMapView, String, String) -> LineLayer? |
MaximAlien
deleted the
maxim/2967-fix-route-line-tracks-traversal-when-custom-line-layer-is-used
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #2967.
In scope of this PR:
routeLineTracksTraversalis enabled on iOS and CarPlay was fixed./cc @ChristianSteffens